From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH 1/3] drm/radeon: move ring locking out of reset path Date: Fri, 29 Jun 2012 17:18:52 +0200 Message-ID: <4FEDC75C.2020003@vodafone.de> References: <1340981103-3717-1-git-send-email-deathsimple@vodafone.de> <1340982540.3562.204.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 333AB9E80D for ; Fri, 29 Jun 2012 08:18:54 -0700 (PDT) In-Reply-To: <1340982540.3562.204.camel@thor.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: =?ISO-8859-1?Q?Michel_D=E4nzer?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 29.06.2012 17:09, Michel D=E4nzer wrote: > On Fre, 2012-06-29 at 16:45 +0200, Christian K=F6nig wrote: >> Hold the ring lock the whole time the reset is in progress, >> otherwise another process can submit new jobs. > Sounds good, but doesn't this create other paths (e.g. initialization, > resume) where the ring is being accessed without holding the lock? Isn't > that a problem? Thought about that also. For init I'm pretty sure that no application can submit commands before = we are done, otherwise we are doomed anyway. For resume I'm not really sure, but I think that applications are = resumed after the hardware driver had a chance of doing so. Christian.