From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: fix up ilk rc6 disabling confusion
Date: Fri, 29 Jun 2012 20:36:14 -0300 [thread overview]
Message-ID: <4FEE3BEE.8030002@linux.intel.com> (raw)
In-Reply-To: <1341005536-5324-1-git-send-email-daniel.vetter@ffwll.ch>
On 06/29/2012 06:32 PM, Daniel Vetter wrote:
> @@ -7270,6 +7270,8 @@ void intel_modeset_cleanup(struct drm_device *dev)
>
> intel_disable_gt_powersave(dev);
>
> + ironlake_teardown_rc6(dev);
> +
Couldn't we pass a true/false parameter to the
intel_disable_gt_powersave for tearing down ironlake RC6 directly instead?
Something like
intel_disable_gt_powersave(struct drm_device *dev, bool teardown_context);
maybe?
Apart from that,
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Eugeni
next prev parent reply other threads:[~2012-06-29 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 21:32 [PATCH] drm/i915: fix up ilk rc6 disabling confusion Daniel Vetter
2012-06-29 23:36 ` Eugeni Dodonov [this message]
2012-06-30 5:51 ` Daniel Vetter
2012-07-01 3:04 ` Ben Widawsky
2012-07-01 10:48 ` Daniel Vetter
2012-07-02 15:44 ` Ben Widawsky
2012-07-02 16:49 ` Daniel Vetter
2012-07-04 7:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEE3BEE.8030002@linux.intel.com \
--to=eugeni.dodonov@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.