From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH] drm/i915: fix up ilk rc6 disabling confusion
Date: Fri, 29 Jun 2012 20:36:14 -0300
Message-ID: <4FEE3BEE.8030002@linux.intel.com>
References: <1341005536-5324-1-git-send-email-daniel.vetter@ffwll.ch>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id AC9809EB51
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Jun 2012 16:34:09 -0700 (PDT)
In-Reply-To: <1341005536-5324-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On 06/29/2012 06:32 PM, Daniel Vetter wrote:
> @@ -7270,6 +7270,8 @@ void intel_modeset_cleanup(struct drm_device *dev)
>  
>  	intel_disable_gt_powersave(dev);
>  
> +	ironlake_teardown_rc6(dev);
> +

Couldn't we pass a true/false parameter to the
intel_disable_gt_powersave for tearing down ironlake RC6 directly instead?

Something like
intel_disable_gt_powersave(struct drm_device *dev, bool teardown_context);

maybe?

Apart from that,
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Eugeni