All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cxgb4i: tcp push bit fix
@ 2012-06-28 23:49 kxie
       [not found] ` <201206282349.q5SNn7H9017422-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: kxie @ 2012-06-28 23:49 UTC (permalink / raw)
  To: linux-scsi, open-iscsi; +Cc: kxie, James.Bottomley, michaelc

[PATCH] cxgb4i: tcp push bit fix

From: Karen Xie <kxie@chelsio.com>

Fixed the parentheses so the tcp push bit would be sent properly.

Signed-off-by: Karen Xie <kxie@chelsio.com>
---
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index 5a4a3bf..9bfc348 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -438,8 +438,8 @@ static inline void make_tx_data_wr(struct cxgbi_sock *csk, struct sk_buff *skb,
 	if (submode)
 		wr_ulp_mode = FW_OFLD_TX_DATA_WR_ULPMODE(ULP2_MODE_ISCSI) |
 				FW_OFLD_TX_DATA_WR_ULPSUBMODE(submode);
-	req->tunnel_to_proxy = htonl(wr_ulp_mode) |
-		 FW_OFLD_TX_DATA_WR_SHOVE(skb_peek(&csk->write_queue) ? 0 : 1);
+	req->tunnel_to_proxy = htonl(wr_ulp_mode |
+		 FW_OFLD_TX_DATA_WR_SHOVE(skb_peek(&csk->write_queue) ? 0 : 1));
 	req->plen = htonl(len);
 	if (!cxgbi_sock_flag(csk, CTPF_TX_DATA_SENT))
 		cxgbi_sock_set_flag(csk, CTPF_TX_DATA_SENT);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cxgb4i: tcp push bit fix
       [not found] ` <201206282349.q5SNn7H9017422-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
@ 2012-06-30  2:41   ` Mike Christie
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2012-06-30  2:41 UTC (permalink / raw)
  To: kxie-ut6Up61K2wZBDgjK7y7TUQ
  Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	open-iscsi-/JYPxA39Uh5TLH3MbocFFw,
	James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk

On 06/28/2012 06:49 PM, kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org wrote:
> [PATCH] cxgb4i: tcp push bit fix
>
> From: Karen Xie <kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
>
> Fixed the parentheses so the tcp push bit would be sent properly.
>
> Signed-off-by: Karen Xie <kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>

Looks ok to me.

Reviewed-by: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-30  2:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 23:49 [PATCH] cxgb4i: tcp push bit fix kxie
     [not found] ` <201206282349.q5SNn7H9017422-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-06-30  2:41   ` Mike Christie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.