From: John <linux@8192.net>
To: Hannes Frederic Sowa <hannes@mailcolloid.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH V3 2/2] bonding support for IPv6 transmit hashing
Date: Sat, 30 Jun 2012 12:38:15 -0700 [thread overview]
Message-ID: <4FEF55A7.6070502@8192.net> (raw)
In-Reply-To: <CAMEyesBOj2cd6sAmowjk1vATrMjxHreeJoDEdksVwENkEWWqLQ@mail.gmail.com>
On 6/30/2012 4:59 AM, Hannes Frederic Sowa wrote:
> On Sat, Jun 30, 2012 at 8:17 AM, John <linux@8192.net> wrote:
>> diff --git a/Documentation/networking/bonding.txt
>> b/Documentation/networking/bonding.txt
>> index bfea8a3..5db14fe 100644
>> --- a/Documentation/networking/bonding.txt
>> +++ b/Documentation/networking/bonding.txt
>> @@ -752,12 +752,22 @@ xmit_hash_policy
>> protocol information to generate the hash.
>>
>> Uses XOR of hardware MAC addresses and IP addresses to
>> - generate the hash. The formula is
>> + generate the hash. The IPv4 formula is
>>
>> (((source IP XOR dest IP) AND 0xffff) XOR
>> ( source MAC XOR destination MAC ))
>> modulo slave count
>>
>> + The IPv6 forumla is
>> +
>> + iphash =
>> + (source ip quad 2 XOR dest IP quad 2) XOR
>> + (source ip quad 3 XOR dest IP quad 3) XOR
>> + (source ip quad 4 XOR dest IP quad 4)
>> +
>> + ((iphash >> 16) XOR (iphash >> 8) XOR iphash)
>> + modulo slave count
>> +
>
> Wouldn't it be beneficial to include the ipv6 flow label in the hash
> calculation?
>
> Greetings,
>
> Hannes
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hannes,
In all of the traffic I inspected I don't believe I saw a single flow
label set. Even if it were set 100% of the time by Linux, any packets
routed or bridged from another operating system wouldn't see any
benefit. The current algorithm distributes the traffic very well, I
don't believe adding the flow label would be beneficial even if it were
set more frequently.
If you feel strongly about its inclusion, though, I am willing to
reconsider.
John
next prev parent reply other threads:[~2012-06-30 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 6:17 [PATCH V3 2/2] bonding support for IPv6 transmit hashing John
2012-06-30 11:59 ` Hannes Frederic Sowa
2012-06-30 19:38 ` John [this message]
2012-07-01 3:57 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEF55A7.6070502@8192.net \
--to=linux@8192.net \
--cc=hannes@mailcolloid.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.