From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vipin Kumar Subject: Re: [PATCH V3 3/4] ASoC: SPEAr spdif_out: Add spdif out support Date: Sun, 1 Jul 2012 12:02:31 +0530 Message-ID: <4FEFEEFF.7040204@st.com> References: <20120628122727.GI28922@opensource.wolfsonmicro.com> <4FED5AB1.6030907@st.com> <20120630183558.GB28922@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from eu1sys200aog112.obsmtp.com (eu1sys200aog112.obsmtp.com [207.126.144.133]) by alsa0.perex.cz (Postfix) with ESMTP id A299324796 for ; Sun, 1 Jul 2012 08:32:41 +0200 (CEST) In-Reply-To: <20120630183558.GB28922@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "alsa-devel@alsa-project.org" , Rajeev KUMAR , "tiwai@suse.de" , spear-devel , "lrg@slimlogic.co.uk" List-Id: alsa-devel@alsa-project.org On 7/1/2012 12:05 AM, Mark Brown wrote: > On Fri, Jun 29, 2012 at 01:05:13PM +0530, Vipin Kumar wrote: >> On 6/28/2012 5:57 PM, Mark Brown wrote: > >>>> + .ops = (struct snd_soc_dai_ops *)&spdif_out_dai_ops, > >>> Why do you need this cast? > >> It was a const I think > > So you've just introduced a bug, then - you're using a const variable in > a non-const context. Don't cast away the const, either arrange for the > ops pointer in the dai to be const or remove the const. sure, i will do that...got it :)