All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <johnstul@us.ibm.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RFC] Potential fix for leapsecond caused futex related load spikes
Date: Sun, 01 Jul 2012 10:28:25 -0700	[thread overview]
Message-ID: <4FF088B9.1000308@us.ibm.com> (raw)
In-Reply-To: <4FF08154.3050407@redhat.com>

On 07/01/2012 09:56 AM, Prarit Bhargava wrote:
>
> John, the issue is that clock_was_set calls on_each_cpu() -- which cannot be
> called from interrupt context as it calls smp_call_function_many().
>
> I don't think you can call call_was_set() from update_wall_time() as
> update_wall_time() is called in interrupt context.
>

Thanks for pointing this out.  Ben Blum also mentioned this last night, 
but I missed the atomic bit instead of the xtime_lock issue.

Reworking the patch now.

thanks again
-john


  reply	other threads:[~2012-07-01 17:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-01 15:28 [PATCH] [RFC] Potential fix for leapsecond caused futex related load spikes Prarit Bhargava
2012-07-01 16:56 ` Prarit Bhargava
2012-07-01 17:28   ` John Stultz [this message]
2012-07-02 10:16     ` Richard Cochran
2012-07-02 16:58       ` John Stultz
2012-07-02 20:08       ` Sytse Wielinga
2012-07-03  9:23         ` Richard Cochran
2012-07-03 12:05           ` Sytse Wielinga
2012-07-03 13:41             ` Richard Cochran
  -- strict thread matches above, loose matches on Subject: below --
2012-07-01  9:36 John Stultz
2012-07-01  9:42 ` John Stultz
2012-07-01 12:00 ` Jan Ceuleers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF088B9.1000308@us.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.