From: Igor Mitsyanko <i.mitsyanko@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-arm: Fix some copy-and-paste errors in cp register names
Date: Sun, 01 Jul 2012 21:42:29 +0400 [thread overview]
Message-ID: <4FF08C05.8090504@gmail.com> (raw)
In-Reply-To: <1340890977-32020-1-git-send-email-peter.maydell@linaro.org>
On 6/28/2012 5:42 PM, Peter Maydell wrote:
> Fix a couple of cases where cp register names were copy-and-pasted.
> These are harmless since we don't use the name for anything (except
> debugging convenience) but could be confusing.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target-arm/helper.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 2309923..7a9ad8d 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -216,9 +216,9 @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
> .access = PL1_W, .type = ARM_CP_NOP },
> { .name = "ISB", .cp = 15, .crn = 7, .crm = 5, .opc1 = 0, .opc2 = 4,
> .access = PL0_W, .type = ARM_CP_NOP },
> - { .name = "ISB", .cp = 15, .crn = 7, .crm = 10, .opc1 = 0, .opc2 = 4,
> + { .name = "DSB", .cp = 15, .crn = 7, .crm = 10, .opc1 = 0, .opc2 = 4,
> .access = PL0_W, .type = ARM_CP_NOP },
> - { .name = "ISB", .cp = 15, .crn = 7, .crm = 10, .opc1 = 0, .opc2 = 5,
> + { .name = "DMB", .cp = 15, .crn = 7, .crm = 10, .opc1 = 0, .opc2 = 5,
> .access = PL0_W, .type = ARM_CP_NOP },
> { .name = "IFAR", .cp = 15, .crn = 6, .crm = 0, .opc1 = 0, .opc2 = 2,
> .access = PL1_RW, .fieldoffset = offsetof(CPUARMState, cp15.c6_insn),
> @@ -346,7 +346,7 @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
> */
> { .name = "DBGDRAR", .cp = 14, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 0,
> .access = PL0_R, .type = ARM_CP_CONST, .resetvalue = 0 },
> - { .name = "DBGDRAR", .cp = 14, .crn = 2, .crm = 0, .opc1 = 0, .opc2 = 0,
> + { .name = "DBGDSAR", .cp = 14, .crn = 2, .crm = 0, .opc1 = 0, .opc2 = 0,
> .access = PL0_R, .type = ARM_CP_CONST, .resetvalue = 0 },
> /* the old v6 WFI, UNPREDICTABLE in v7 but we choose to NOP */
> { .name = "NOP", .cp = 15, .crn = 7, .crm = 0, .opc1 = 0, .opc2 = 4,
>
just like it named in architecture reference manual
Reviewed-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
parent reply other threads:[~2012-07-01 17:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1340890977-32020-1-git-send-email-peter.maydell@linaro.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF08C05.8090504@gmail.com \
--to=i.mitsyanko@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.