From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: Re: Request VFIO inclusion in linux-next Date: Mon, 02 Jul 2012 13:41:09 +1000 Message-ID: <4FF11855.2060605@ozlabs.ru> References: <1340686552.1207.128.camel@bling.home> <20120627123733.GA5449@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120627123733.GA5449@mwanda> Sender: linux-next-owner@vger.kernel.org To: Dan Carpenter Cc: Alex Williamson , Stephen Rothwell , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman , linux-kernel , kvm , linux-pci , iommu , qemu-devel , Benjamin Herrenschmidt , David Gibson , chrisw , "Roedel, Joerg" , linux-next@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On 27/06/12 22:37, Dan Carpenter wrote: > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: >> Hi, >> >> VFIO has been kicking around for well over a year now and has been >> posted numerous times for review. The pre-requirements are finally >> available in linux-next (or will be in the 20120626 build) so I'd like >> to request a new branch be included in linux-next with a goal of being >> accepted into v3.6. >> > > Could you run Sparse over the driver? > http://lwn.net/Articles/205624/ > > It reports a bunch of endian problems. Some are definitely bugs > like: > *prev |= cpu_to_le32((u32)epos << 20); What is wrong here? -- Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlXVq-0006wf-LA for qemu-devel@nongnu.org; Sun, 01 Jul 2012 23:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlXVo-0003x4-RD for qemu-devel@nongnu.org; Sun, 01 Jul 2012 23:41:22 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:51611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlXVo-0003wp-Kq for qemu-devel@nongnu.org; Sun, 01 Jul 2012 23:41:20 -0400 Received: by dadn2 with SMTP id n2so7562982dad.4 for ; Sun, 01 Jul 2012 20:41:18 -0700 (PDT) Message-ID: <4FF11855.2060605@ozlabs.ru> Date: Mon, 02 Jul 2012 13:41:09 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1340686552.1207.128.camel@bling.home> <20120627123733.GA5449@mwanda> In-Reply-To: <20120627123733.GA5449@mwanda> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Request VFIO inclusion in linux-next List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dan Carpenter Cc: Stephen Rothwell , kvm , Greg Kroah-Hartman , "Roedel, Joerg" , linux-kernel , iommu , qemu-devel , chrisw , Alex Williamson , linux-next@vger.kernel.org, linux-pci , Andrew Morton , Linus Torvalds , David Gibson On 27/06/12 22:37, Dan Carpenter wrote: > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: >> Hi, >> >> VFIO has been kicking around for well over a year now and has been >> posted numerous times for review. The pre-requirements are finally >> available in linux-next (or will be in the 20120626 build) so I'd like >> to request a new branch be included in linux-next with a goal of being >> accepted into v3.6. >> > > Could you run Sparse over the driver? > http://lwn.net/Articles/205624/ > > It reports a bunch of endian problems. Some are definitely bugs > like: > *prev |= cpu_to_le32((u32)epos << 20); What is wrong here? -- Alexey