All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Wang <jason77.wang@gmail.com>
To: Hui Wang <jason77.wang@gmail.com>,
	mkl@pengutronix.de, shawn.guo@linaro.org, wg@grandegger.com,
	linux-can@vger.kernel.org
Subject: Re: [RFC PATCH] can: dev: update rx state in the can_get_echo_skb()
Date: Mon, 2 Jul 2012 11:42:18 +0800	[thread overview]
Message-ID: <4FF1189A.8080900@gmail.com> (raw)
In-Reply-To: <20120628105948.GC418@vandijck-laurijssen.be>

Kurt Van Dijck wrote:
> Hi,
>
> A loopback packet enters the rx interface of the CAN subsystem,
> but it had never entered the chip's receive path.
> IMHO it's bad to alter the chip's statistics the way you propose.
>   
Your explanation makes sense to me.
> Are you interested in the number of packets/bytes
> that you were able to receive on your socket?
> How about adding echo statistics in the CAN device stats,
> as shown in
> $ ip -d -s link show can0
>   
It can work.

Thanks,
Hui.
> Kind regards,
> Kurt
>
> On Thu, Jun 28, 2012 at 05:42:20PM +0800, Hui Wang wrote:
>   


      reply	other threads:[~2012-07-02  3:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  9:42 [RFC PATCH] can: dev: update rx state in the can_get_echo_skb() Hui Wang
2012-06-28 10:59 ` Wolfgang Grandegger
2012-07-02  3:36   ` Hui Wang
2012-06-28 10:59 ` Kurt Van Dijck
2012-07-02  3:42   ` Hui Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF1189A.8080900@gmail.com \
    --to=jason77.wang@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.