From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajeev kumar Subject: Re: [PATCH V3 3/4] ASoC: SPEAr spdif_out: Add spdif out support Date: Mon, 2 Jul 2012 10:30:25 +0530 Message-ID: <4FF12AE9.6000001@st.com> References: <20120628122727.GI28922@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from eu1sys200aog113.obsmtp.com (eu1sys200aog113.obsmtp.com [207.126.144.135]) by alsa0.perex.cz (Postfix) with ESMTP id 82F7F2459C for ; Mon, 2 Jul 2012 07:00:34 +0200 (CEST) In-Reply-To: <20120628122727.GI28922@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "tiwai@suse.de" , Vipin KUMAR , "alsa-devel@alsa-project.org" , "lrg@slimlogic.co.uk" List-Id: alsa-devel@alsa-project.org Hello Mark, On 6/28/2012 5:57 PM, Mark Brown wrote: >> +int spdif_soc_dai_probe(struct snd_soc_dai *dai) >> > +{ >> > + struct snd_soc_card *card = dai->card; >> > + struct snd_soc_pcm_runtime *rtd = card->rtd; >> > + struct snd_soc_codec *codec = rtd->codec; >> > + >> > + return snd_soc_add_codec_controls(codec, spdif_out_controls, >> > + ARRAY_SIZE(spdif_out_controls)); > We should add a framework thing for this... > I was going through the simaple-card.c file and I think that the above is possible if we have a pointer of "snd_kcontrol_new" in asoc_simple_card_info structure. In this case we can pass all the controls from board file (arch/arm/mach-*). Please share your opinion. or, Is there any other way to do this ? Best Regards Rajeev