From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Erik Rull <erik.rull@rdsoftware.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete
Date: Mon, 02 Jul 2012 13:08:03 +0200 [thread overview]
Message-ID: <4FF18113.4080403@redhat.com> (raw)
In-Reply-To: <4FEDD75A.1010705@siemens.com>
On 06/29/12 18:27, Jan Kiszka wrote:
> Due to queuing/pipelining, there can now be multiple packets per
> endpoint in flight. So the assertion in usb_packet_complete became wrong
> and can cause bogus QEMU terminations. Seen with a passed-through USB
> headset.
NAK. The assert doesn't protect against multiple packets in flight, but
against packet reorderng.
Need to understand why to assert actually triggers.
cheers,
Gerd
parent reply other threads:[~2012-07-02 11:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4FEDD75A.1010705@siemens.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF18113.4080403@redhat.com \
--to=kraxel@redhat.com \
--cc=erik.rull@rdsoftware.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.