From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slfaf-0004jj-BW for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:18:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slfad-0004qv-K6 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:18:52 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:41825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slfad-0004qd-Dy for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:18:51 -0400 Received: from eusync1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M6J005PT8W3C120@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 02 Jul 2012 13:19:15 +0100 (BST) Received: from [106.109.9.244] by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M6J00A0F8V8ZG30@eusync1.samsung.com> for qemu-devel@nongnu.org; Mon, 02 Jul 2012 13:18:46 +0100 (BST) Date: Mon, 02 Jul 2012 16:18:44 +0400 From: Igor Mitsyanko In-reply-to: <4FF18992.3050208@suse.de> Message-id: <4FF191A4.9060700@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-15; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <1340610940-923-1-git-send-email-o.ogurtsov@samsung.com> <1340610940-923-2-git-send-email-o.ogurtsov@samsung.com> <4FE82E60.5050007@suse.de> <4FE84FAE.1050709@samsung.com> <4FE852F7.9060405@suse.de> <4FE92A16.5060705@samsung.com> <4FED9EFA.8040402@suse.de> <4FF06C3C.2070706@redhat.com> <4FF18992.3050208@suse.de> Subject: Re: [Qemu-devel] [PATCH] Exynos4: added RTC device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, Evgeny Voevodin , qemu-devel@nongnu.org, kyungmin.park@samsung.com, Paolo Bonzini , Oleg Ogurtsov On 07/02/2012 03:44 PM, Andreas F=E4rber wrote: > Am 01.07.2012 17:26, schrieb Paolo Bonzini: >> Il 29/06/2012 14:26, Andreas F=E4rber ha scritto: >>>>> >>>>> Oh, I see. Should we place this device to hw/Makefile.objs in v= 2? >>> That would've been nice, but I'll do it as a follow-up now. >> >> Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introducing >> CONFIG_EXYNOS can be done later). > > I have a patch in the works, but exynos turned out more difficult t= han > other devices (also OMAP and PXA2xx) because it uses a shared > .h header that uses CPU. For tegra I fixed that by adding = an > #ifdef NEED_CPU_H for the appropriate parts. > > Andreas > I think we can drop ARMCPU *cpu[] member from Exynos4210State and jus= t=20 use local variable in exynos4210_init() instead, like everyone else d= oes. exynos4210_write_secondary() prototype can be moved from exynos4210.h= =20 header to exynos4_boards.c, or we can pass arm_boot_info=20 exynos4_board_binfo to Exynos4210 SoC init function exynos4210_init()= to=20 initialize .write_secondary_boot field there.