From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SlkXw-0002hd-32
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 13:36:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SlkXp-0000HC-Ik
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 13:36:23 -0400
Received: from co1ehsobe001.messaging.microsoft.com ([216.32.180.184]:59791
	helo=co1outboundpool.messaging.microsoft.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1SlkXp-0000Gd-Ac
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 13:36:17 -0400
Message-ID: <4FF1D4F8.1020708@freescale.com>
Date: Mon, 2 Jul 2012 12:06:00 -0500
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
References: <20120627235055.GA9149@tyr.buserror.net> <4FF1D151.6050604@suse.de>
In-Reply-To: <4FF1D151.6050604@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] PPC: e500: rename mpc8544ds into
 generic file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On 07/02/2012 11:50 AM, Andreas F=C3=A4rber wrote:
> Hi Scott,
>=20
> Am 28.06.2012 01:50, schrieb Scott Wood:
>> Rename the file (with no changes other than fixing up the header paths=
)
>> in preparation for refactoring into a generic e500 platform.  Also mov=
e
>> it into the newly created ppc/ directory.
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> ---
>>  hw/ppc/Makefile.objs                   |    2 +-
>>  hw/{ppce500_mpc8544ds.c =3D> ppc/e500.c} |   16 ++++++++--------
>>  2 files changed, 9 insertions(+), 9 deletions(-)
>>  rename hw/{ppce500_mpc8544ds.c =3D> ppc/e500.c} (99%)
>>
>> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
>> index aa4bbeb..aa77f64 100644
>> --- a/hw/ppc/Makefile.objs
>> +++ b/hw/ppc/Makefile.objs
>> @@ -15,7 +15,7 @@ obj-$(CONFIG_PSERIES) +=3D spapr_pci.o pci-hotplug.o=
 spapr_iommu.o
>>  obj-y +=3D ppc4xx_devs.o ppc4xx_pci.o ppc405_uc.o ppc405_boards.o
>>  obj-y +=3D ppc440_bamboo.o
>>  # PowerPC E500 boards
>> -obj-$(CONFIG_FDT) +=3D ppce500_mpc8544ds.o mpc8544_guts.o ppce500_spi=
n.o
>> +obj-$(CONFIG_FDT) +=3D ppc/e500.o mpc8544_guts.o ppce500_spin.o
>>  # PowerPC 440 Xilinx ML507 reference board.
>>  obj-y +=3D virtex_ml507.o
>>  # PowerPC OpenPIC
> [snip]
>=20
> The location seems perfect for the file and nicely simplifies the file
> name, but could we avoid ../ppc/ by doing:
>=20
> obj-$(CONFIG_FDT) +=3D e500.o
>=20
> further down after the ../ prefix has been added for the legacy files?

Ah, didn't notice that down there.  Will fix.

-Scott