From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: rpurdie@rpsys.net, linux-leds@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH 2/2] leds: Convert S3C24XX LED driver to gpiolib API
Date: Mon, 02 Jul 2012 22:18:44 +0200 [thread overview]
Message-ID: <4FF20224.4020203@gmail.com> (raw)
In-Reply-To: <CAK5ve-JRmb93+KVFVfeDbP7i_7n3dN22WcsyLurgAbvkU5e=mA@mail.gmail.com>
Hi,
On 07/02/2012 05:35 AM, Bryan Wu wrote:
> On Sat, Jun 30, 2012 at 8:30 PM, Sylwester Nawrocki
> <sylvester.nawrocki@gmail.com> wrote:
>> The s3c2410_gpio* calls are obsolete and have been scheduled for
>> removal since several kernel releases. Remove them and use common
>> gpiolib API instead.
>> This patch also adds gpio_request/gpio_free call for API corectness.
>>
>> It is a prerequisite for removal of the S3C24XX SoC specific
>> arch/arm/plat-samsung/include/gpio-fns.h header.
>>
>> Tested on Micro2440-SDK.
>>
>
> Overall, these 2 patches are good. I'm just curious why not we just
> use generic led-gpio driver to replace this one.
Thank you for the suggestion, I wasn't really aware of generic leds-gpio
driver... This could be nice optimization. However my intention was
to just clean up the GPIO bits, with minimal changes to other subsystems.
I could check and see how it could be done perhaps as a next step ? There
is a few (old) boards that use this driver and converting them would
delay the GPIO patches even further...
Also generic led-gpio has some limitations, e.g. I couldn't see it supports
tri-stating a GPIO when a LED is off. Probably this feature could be added.
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-07-02 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 12:30 [PATCH 1/2] leds: Convert S3C24XX LED driver to devm_kzalloc() Sylwester Nawrocki
2012-06-30 12:30 ` [PATCH 2/2] leds: Convert S3C24XX LED driver to gpiolib API Sylwester Nawrocki
2012-07-02 3:35 ` Bryan Wu
2012-07-02 20:18 ` Sylwester Nawrocki [this message]
2012-07-03 2:30 ` Bryan Wu
2012-07-03 21:10 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF20224.4020203@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=ben-linux@fluff.org \
--cc=bryan.wu@canonical.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.