From: Mark Hatle <mark.hatle@windriver.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] libc-common: Allow debug package to append, not set depends
Date: Mon, 2 Jul 2012 15:37:55 -0500 [thread overview]
Message-ID: <4FF206A3.6000108@windriver.com> (raw)
In-Reply-To: <1341260763.2886.34.camel@x121e.pbcl.net>
On 7/2/12 3:26 PM, Phil Blundell wrote:
> On Fri, 2012-06-29 at 19:22 -0500, Mark Hatle wrote:
>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>
> This patch has no checkin message (other than the subject line) which is
> contrary to our fine guidelines. What bug is this fixing?
Exactly what the subject is. The libc-common.bbclass needs to be able to append
the RPROVIDES, RCONFLICT_, RREPLACES_ and not just -set- them.
The guidelines say that if the subject and code explain what is being changed,
then repeating the subject is frowned upon.
> Also, the subject line talks about "depends" but the patch actually
> modifies the way that RPROVIDES/RCONFLICTS/RREPLACES are set and I'm not
> sure that most people would class those as "depends".
Sorry, terminology then.. I consider these all depends.
I can reword it, but it was clear to me when I wrote it that the subject and
patch itself explained what was happening.
--Mark
> p.
>
>> ---
>> meta/classes/libc-common.bbclass | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/classes/libc-common.bbclass b/meta/classes/libc-common.bbclass
>> index 9b91f0a..8145d64 100644
>> --- a/meta/classes/libc-common.bbclass
>> +++ b/meta/classes/libc-common.bbclass
>> @@ -29,7 +29,7 @@ python populate_packages_prepend () {
>> d.setVar('PKG_'+bpn+'-dev', 'libc6-dev')
>> d.setVar('PKG_'+bpn+'-dbg', 'libc6-dbg')
>> # For backward compatibility with old -dbg package
>> - d.setVar('RPROVIDES_' + bpn + '-dbg', 'libc-dbg')
>> - d.setVar('RCONFLICTS_' + bpn + '-dbg', 'libc-dbg')
>> - d.setVar('RREPLACES_' + bpn + '-dbg', 'libc-dbg')
>> + d.appendVar('RPROVIDES_' + bpn + '-dbg', ' libc-dbg')
>> + d.appendVar('RCONFLICTS_' + bpn + '-dbg', ' libc-dbg')
>> + d.appendVar('RREPLACES_' + bpn + '-dbg', ' libc-dbg')
>> }
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2012-07-02 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 0:22 [PATCH 0/2] SDK related misc changes Mark Hatle
2012-06-30 0:22 ` [PATCH 1/2] libc-common: Allow debug package to append, not set depends Mark Hatle
2012-07-02 20:26 ` Phil Blundell
2012-07-02 20:37 ` Mark Hatle [this message]
2012-06-30 0:22 ` [PATCH 2/2] package.bbclass: Allow a package to skip per file dependency generation Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF206A3.6000108@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.