From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slnhy-000603-Cu for qemu-devel@nongnu.org; Mon, 02 Jul 2012 16:58:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slnhv-0000p3-TG for qemu-devel@nongnu.org; Mon, 02 Jul 2012 16:58:57 -0400 Message-ID: <4FF20B89.7030007@suse.de> Date: Mon, 02 Jul 2012 22:58:49 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <20120627235055.GA9149@tyr.buserror.net> <4FF1D151.6050604@suse.de> <4FF1D4F8.1020708@freescale.com> <4FF20575.9090708@freescale.com> In-Reply-To: <4FF20575.9090708@freescale.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] PPC: e500: rename mpc8544ds into generic file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Wood Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 02.07.2012 22:32, schrieb Scott Wood: > On 07/02/2012 12:06 PM, Scott Wood wrote: >> On 07/02/2012 11:50 AM, Andreas F=C3=A4rber wrote: >>> Am 28.06.2012 01:50, schrieb Scott Wood: >>>> hw/ppc/Makefile.objs | 2 +- >>>> hw/{ppce500_mpc8544ds.c =3D> ppc/e500.c} | 16 ++++++++-------- >>>> 2 files changed, 9 insertions(+), 9 deletions(-) >>>> rename hw/{ppce500_mpc8544ds.c =3D> ppc/e500.c} (99%) >>>> >>>> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs >>>> index aa4bbeb..aa77f64 100644 >>>> --- a/hw/ppc/Makefile.objs >>>> +++ b/hw/ppc/Makefile.objs >>>> @@ -15,7 +15,7 @@ obj-$(CONFIG_PSERIES) +=3D spapr_pci.o pci-hotplug= .o spapr_iommu.o >>>> obj-y +=3D ppc4xx_devs.o ppc4xx_pci.o ppc405_uc.o ppc405_boards.o >>>> obj-y +=3D ppc440_bamboo.o >>>> # PowerPC E500 boards >>>> -obj-$(CONFIG_FDT) +=3D ppce500_mpc8544ds.o mpc8544_guts.o ppce500_s= pin.o >>>> +obj-$(CONFIG_FDT) +=3D ppc/e500.o mpc8544_guts.o ppce500_spin.o >>>> # PowerPC 440 Xilinx ML507 reference board. >>>> obj-y +=3D virtex_ml507.o >>>> # PowerPC OpenPIC >>> [snip] >>> >>> The location seems perfect for the file and nicely simplifies the fil= e >>> name, but could we avoid ../ppc/ by doing: >>> >>> obj-$(CONFIG_FDT) +=3D e500.o >>> >>> further down after the ../ prefix has been added for the legacy files= ? >> >> Ah, didn't notice that down there. Will fix. >=20 > Wait, how will appending ../ help with the ppc/ prefix? hw/ppc/ is the current directory. Therefore a ../ prefix is added for all hw/ files in obj-y last thing in the Makefile. Your patch thus constructs the path hw/ppc/../ppc/e500.o. My suggestion was to simply use hw/ppc/e500.o. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg