From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org, Stuart Yoder <stuart.yoder@freescale.com>
Subject: Re: [PATCH] PPC: use CURRENT_THREAD_INFO instead of open coded assembly
Date: Mon, 2 Jul 2012 16:31:47 -0500 [thread overview]
Message-ID: <4FF21343.20408@freescale.com> (raw)
In-Reply-To: <DAF1D512-B0CF-497D-8626-1C75103C6EA0@suse.de>
On 07/02/2012 04:27 PM, Alexander Graf wrote:
>
> On 02.07.2012, at 23:26, Benjamin Herrenschmidt wrote:
>
>> On Mon, 2012-07-02 at 22:59 +0200, Alexander Graf wrote:
>>> This should go into an #ifdef __ASSEMBLY__ block, right? :)
>>
>> We almost never use #ifdef __ASSEMBLY__, we use it the other way
>> around, to prevent C stuff from being included in assembly. The
>> other way around is legit since things might be used in inline asm
>> for example.
>
> I'm not sure I want to see this bit of code used as is in inline asm
> :). I don't even think it's possible, since it's a full statement.
> Either way, it's safer with the guard.
Safer from what? It won't be expanded unless referenced. How is this
better than putting ifdefs on #includes, prototypes, struct definitions,
etc.? The ifdef is just clutter.
-Scott
next prev parent reply other threads:[~2012-07-02 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 20:56 [PATCH] PPC: use CURRENT_THREAD_INFO instead of open coded assembly Stuart Yoder
2012-07-02 20:59 ` Alexander Graf
2012-07-02 21:26 ` Benjamin Herrenschmidt
2012-07-02 21:27 ` Alexander Graf
2012-07-02 21:31 ` Scott Wood [this message]
2012-07-02 21:34 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF21343.20408@freescale.com \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.