From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Slyq2-0007ww-UD
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 04:52:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Slypw-0002Ph-OB
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 04:52:02 -0400
Received: from goliath.siemens.de ([192.35.17.28]:18918)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Slypw-0002PM-E6
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 04:51:56 -0400
Message-ID: <4FF2B2A9.1000307@siemens.com>
Date: Tue, 03 Jul 2012 10:51:53 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1341245761-30942-1-git-send-email-kraxel@redhat.com>
	<4FF2A379.7040403@siemens.com> <4FF2AB70.5080307@redhat.com>
	<4FF2B0A8.1070806@siemens.com>
In-Reply-To: <4FF2B0A8.1070806@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "erik.rull@rdsoftware.de" <erik.rull@rdsoftware.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2012-07-03 10:43, Jan Kiszka wrote:
> On 2012-07-03 10:21, Gerd Hoffmann wrote:
>> On 07/03/12 09:47, Jan Kiszka wrote:
>>> On 2012-07-02 18:16, Gerd Hoffmann wrote:
>>>> Add support for (re-)initializing endpoints which belong to a specific
>>>> interface only.  Use this in usb-host when changing altsetting for an
>>>> interface, so other interfaces are not disturbed.
>>>>
>>>
>>> qemu-system-x86_64: /data/qemu/hw/usb/host-linux.c:1220:
>>> usb_linux_update_endp_table: Assertion `usb_ep_get_type(&s->dev, pid,
>>> ep) == 255' failed.
>>>
>>> Do you need a trace again?
>>
>> Don't think so.  Alternative fix attached.
> 
> Looks good here. No crashes so far, sound is playing.
> 

BTW, there are still plenty of "husb: out of buffers for iso stream"
messages. Can we do anything about it, or does the the guest selects too
few buffers here (for a virtualized setup)?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux