From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 03 Jul 2012 11:11:19 +0200 Subject: [U-Boot] arm, kirkwood: KWGBE_PORT_SERIAL_CONTROL1_REG define correct? Message-ID: <4FF2B737.9060309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Prafulla, I see in current mainline code: arch/arm/include/asm/arch-kirkwood/cpu.h 35 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x) \ 36 ((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c) with results in: if _x = 0 KW_EGIGA1_BASE and if _x = 1 KW_EGIGA0_BASE ^ ^ ^ ^ is selected ... is this correct? I read _x as port and so this define swaps the base addresses, or do I miss something? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany