From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm4Qq-0004Lp-80 for qemu-devel@nongnu.org; Tue, 03 Jul 2012 10:50:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sm4Qk-0000rf-OV for qemu-devel@nongnu.org; Tue, 03 Jul 2012 10:50:23 -0400 Received: from david.siemens.de ([192.35.17.14]:24456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm4Qk-0000qS-Fb for qemu-devel@nongnu.org; Tue, 03 Jul 2012 10:50:18 -0400 Message-ID: <4FF306A5.6060000@siemens.com> Date: Tue, 03 Jul 2012 16:50:13 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4FF159C1.8080508@siemens.com> <4FF3048F.2080403@weilnetz.de> In-Reply-To: <4FF3048F.2080403@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , qemu-devel On 2012-07-03 16:41, Stefan Weil wrote: > Am 02.07.2012 10:20, schrieb Jan Kiszka: >> Let the text console cursor blink at 5 HZ. >> >> Signed-off-by: Jan Kiszka >> --- >> console.c | 26 +++++++++++++++++++++++++- >> 1 files changed, 25 insertions(+), 1 deletions(-) >> > > Hi Jan, > > I know that there was a "bug" report. Nevertheless I'd like > to ask whether QEMU really needs a blinking text cursor. > > Blinking cursors are a matter of taste. I personally don't > want a blinking cursors. Nor do I want programs which > wake my cpu 5 times a second for something which I > don't need. > > It's possible to get a blinking cursor without your patch > by redirecting QEMU's text console to one of the common > X terminal emulations (xterm, konsole, ...). > > When QEMU gets GTK support, it might use a terminal > emulation which allows configurable cursor blinking. > IMHO that would be better than implementing that feature > in QEMU code. > > That's why I suggest not to apply the patch. Well, *if* there should be heavy resistance against this patch, we may postpone it. But I consider the feature useful to identify the cursor position and check visually the liveliness of QEMU. However, the VGA blinking is a feature that should go in, specifically as there is no impact on wakeups and it fixes an emulation deficit. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux