Re: [PATCH] brcmsmac: fix brcms_c_regd_init() which crashed after 11ad patch

["Arend van Spriel" <arend@broadcom.com>]

On 07/03/2012 03:26 PM, Seth Forshee wrote:
> On Tue, Jul 03, 2012 at 03:14:40PM +0200, Arend van Spriel wrote:
>> This patch fixes an OOPS in brcmsmac driver, which was introduced
>> by the 11ad patch 'cfg80211: add 802.11ad (60gHz band) support'.
>> The value IEEE80211_NUM_BANDS increased, which was used in the
>> brcms_c_regd_init() function.
>>
>> Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
>> Cc: Johannes Berg <johannes.berg@intel.com>
>> Cc: Seth Forshee <seth.forshee@canonical.com>
>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> 
> Acked-by: Seth Forshee <seth.forshee@canonical.com>
> 
> Just one minor nit ...
> 
>> +		if (band_idx == BAND_2G_INDEX) {
>> +			sband = wiphy->bands[IEEE80211_BAND_2GHZ];
>> +		} else {
>> +			sband = wiphy->bands[IEEE80211_BAND_5GHZ];
>> +		}
> 
> No need for braces here.

I hate nits so I will remove them.

Gr. AvS