From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Du, Changbin" <changbin.du@gmail.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org, ben@simtec.co.uk,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: s3c-hsotg: fix core reset timeout failure
Date: Tue, 03 Jul 2012 21:20:53 +0400 [thread overview]
Message-ID: <4FF329F5.6000801@mvista.com> (raw)
In-Reply-To: <4ff252e7.08d4440a.38ee.ffffd7b9@mx.google.com>
Hello.
On 07/03/2012 06:03 AM, Du, Changbin wrote:
> The timeout values were 1000 and timeout issue occured many times on my
> s3c6410 Soc based board (mostly when booting whith USB cable not
> connected). This patch increase the values to 10000 to guarantee the
> success of reset.
> Having set timeout to 10000, I printed the remained timeout values
> which can cause timeout issue before this change (tested several times):
> the first timeout value remained:
> timeout = 8079
> timeout = 8079
> timeout = 8078
> timeout = 8081
> the second timeout value remained:
> timeout = 7940
> timeout = 7945
> timeout = 7940
> timeout = 7938
> Seeing from above values, I think 10000 is big enough.
> Signed-off-by: Du, Changbin <changbin.du@gmail.com>
> ---
> drivers/usb/gadget/s3c-hsotg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index f4abb0e..f3e2234 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -2215,7 +2215,7 @@ static int s3c_hsotg_corereset(struct s3c_hsotg
> *hsotg)
Your patch is line wrapped; seems easy to fix manually while applying though...
WBR, Sergei
next prev parent reply other threads:[~2012-07-03 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 2:03 [PATCH 1/1] usb: gadget: s3c-hsotg: fix core reset timeout failure Du, Changbin
2012-07-03 6:44 ` ABRAHAM, KISHON VIJAY
2012-07-03 10:00 ` Du, Changbin
2012-07-03 17:20 ` Sergei Shtylyov [this message]
2012-07-04 1:48 ` Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF329F5.6000801@mvista.com \
--to=sshtylyov@mvista.com \
--cc=balbi@ti.com \
--cc=ben@simtec.co.uk \
--cc=changbin.du@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.