From: Jonathan Cameron <jic23@kernel.org>
To: "Zhang, Sonic" <Sonic.Zhang@analog.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/3] staging iio adt7410: sysfs store function must return length
Date: Tue, 03 Jul 2012 21:08:20 +0100 [thread overview]
Message-ID: <4FF35134.7000506@kernel.org> (raw)
In-Reply-To: <DB904C5425BA6F4E8424B3B51A1414D17140805E77@NWD2CMBX1.ad.analog.com>
On 07/03/2012 11:41 AM, Zhang, Sonic wrote:
> Acked-by: Sonic Zhang <sonic.zhang@analog.com>
>
>> -----Original Message-----
>> From: Sascha Hauer [mailto:s.hauer@pengutronix.de]
>> Sent: Tuesday, July 03, 2012 5:21 PM
>> To: linux-iio@vger.kernel.org
>> Cc: Jonathan Cameron; Zhang, Sonic; Sascha Hauer
>> Subject: [PATCH 1/3] staging iio adt7410: sysfs store function must return length
>>
>> Otherwise a write to the resolution entry never returns.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
merged to fixes. Thanks.
>> ---
>> drivers/staging/iio/adc/adt7410.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/adt7410.c b/drivers/staging/iio/adc/adt7410.c
>> index d7d9ad9..fa54a40 100644
>> --- a/drivers/staging/iio/adc/adt7410.c
>> +++ b/drivers/staging/iio/adc/adt7410.c
>> @@ -257,7 +257,7 @@ static ssize_t adt7410_store_resolution(struct device
>> *dev,
>>
>> chip->config = config;
>>
>> - return ret;
>> + return len;
>> }
>>
>> static IIO_DEVICE_ATTR(resolution, S_IRUGO | S_IWUSR,
>> --
>> 1.7.10
>>
>
>
next prev parent reply other threads:[~2012-07-03 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 9:21 [PATCH] staging iio adt7410: some improvements Sascha Hauer
2012-07-03 9:21 ` [PATCH 1/3] staging iio adt7410: sysfs store function must return length Sascha Hauer
2012-07-03 10:41 ` Zhang, Sonic
2012-07-03 20:08 ` Jonathan Cameron [this message]
2012-07-03 9:21 ` [PATCH 2/3] staging iio adt7410: fix 13bit mode Sascha Hauer
2012-07-03 10:41 ` Zhang, Sonic
2012-07-03 20:12 ` Jonathan Cameron
2012-07-03 9:21 ` [PATCH 3/3] staging iio adt7410: make 16bit mode default Sascha Hauer
2012-07-03 10:42 ` Zhang, Sonic
2012-07-03 20:19 ` Jonathan Cameron
2012-07-04 6:27 ` Sascha Hauer
2012-07-04 6:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF35134.7000506@kernel.org \
--to=jic23@kernel.org \
--cc=Sonic.Zhang@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.