From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: rpurdie@rpsys.net, linux-leds@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH 2/2] leds: Convert S3C24XX LED driver to gpiolib API
Date: Tue, 03 Jul 2012 23:10:41 +0200 [thread overview]
Message-ID: <4FF35FD1.4060402@gmail.com> (raw)
In-Reply-To: <CAK5ve-+k0vJCDrrLoVTrtCDz0MrfootreAsy2+O6YRss1apB=g@mail.gmail.com>
On 07/03/2012 04:30 AM, Bryan Wu wrote:
...
>>> Overall, these 2 patches are good. I'm just curious why not we just
>>> use generic led-gpio driver to replace this one.
>>
>> Thank you for the suggestion, I wasn't really aware of generic leds-gpio
>> driver... This could be nice optimization. However my intention was
>> to just clean up the GPIO bits, with minimal changes to other subsystems.
>> I could check and see how it could be done perhaps as a next step ?
>
> Sure, no problem. I will merge these 2 patches soon.
Thank you.
>> There is a few (old) boards that use this driver and converting them would
>> delay the GPIO patches even further...
>>
>> Also generic led-gpio has some limitations, e.g. I couldn't see it supports
>> tri-stating a GPIO when a LED is off. Probably this feature could be added.
>>
>
> Good point, I will help to take a look.
I should get back to this when I find some more time.
That might not be difficult, probably gpio_request_one() with GPIOF_OPEN_DRAIN/
GPIOF_OPEN_SOURCE flag instead of gpio_request() would do.
--
Regards,
Sylwester
prev parent reply other threads:[~2012-07-03 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 12:30 [PATCH 1/2] leds: Convert S3C24XX LED driver to devm_kzalloc() Sylwester Nawrocki
2012-06-30 12:30 ` [PATCH 2/2] leds: Convert S3C24XX LED driver to gpiolib API Sylwester Nawrocki
2012-07-02 3:35 ` Bryan Wu
2012-07-02 20:18 ` Sylwester Nawrocki
2012-07-03 2:30 ` Bryan Wu
2012-07-03 21:10 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF35FD1.4060402@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=ben-linux@fluff.org \
--cc=bryan.wu@canonical.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.