From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration
Date: Wed, 04 Jul 2012 13:26:27 +0900 [thread overview]
Message-ID: <4FF3C5F3.1050700@samsung.com> (raw)
In-Reply-To: <CALrBrZ2jJcheMe29Vgari=gVz9n1yM+h+wWBC_CqBUov2ocNtg@mail.gmail.com>
On 4 July 2012 12:29, Minkyu Kang wrote:
> On 2 July 2012 20:18, Donghwa Lee <dh09.lee@samsung.com> wrote:
>> To avoid compilers error in case of not using
>> CONFIG_EXYNOS_MIPI_DSIM, add no operation function.
>>
>> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
>> index 9a7cbeb..b73263d 100644
>> --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
>> +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
>> @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
>> void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
>> };
>>
>> +#ifdef CONFIG_EXYNOS_MIPI_DSIM
>> int exynos_mipi_dsi_init(void);
>> +#else
>> +int exynos_mipi_dsi_init(void)
>> +{
>> + return 0;
>> +}
>> +#endif
>
> How about weak function instead of ifdef?
>
> Thanks.
> Minkyu Kang.
Ok, It looks like better. I will fix it later.
Thank you,
Donghwa Lee.
prev parent reply other threads:[~2012-07-04 4:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 11:18 [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration Donghwa Lee
2012-07-04 3:29 ` Minkyu Kang
2012-07-04 4:26 ` Donghwa Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3C5F3.1050700@samsung.com \
--to=dh09.lee@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.