From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: [RFC][PATCH] libata: enable SATA disk fua detection on default Date: Wed, 04 Jul 2012 10:36:40 +0400 Message-ID: <4FF3E478.50609@msgid.tls.msk.ru> References: <1336447443-4685-1-git-send-email-wenqing.lz@taobao.com> <20120703090441.GA4804@gmail.com> <4FF351F8.1000003@msgid.tls.msk.ru> <20120704024715.GA17095@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from isrv.corpit.ru ([86.62.121.231]:46392 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab2GDGgn (ORCPT ); Wed, 4 Jul 2012 02:36:43 -0400 In-Reply-To: <20120704024715.GA17095@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Zheng Liu On 04.07.2012 06:47, Zheng Liu wrote: [] >> I guess it can be enabled after LOTS of testing of various drives out >> there, which shows that no current drives have issues with FUA anymore, >> and after building a black-list of devices which misbehave. It is quite >> a big project, I think. But what it gives us in return? >> >> (I've no idea if this is the right answer, speaking of myself only) > > Thanks for the reply. Indeed it is quite a big project but we enable > FUA feature for SAS disk. Is there any differences? Yes, there's a very big difference with SAS disks. Even in parallel SCSI world DPO/FUA has been enabled since the day it has been implemented IIRC, because, apparently, hardware raid controllers enabled it too. In other words, it has been tested and proved to be working even before linux implementation. When first SAS disks started appearing, DPO/FUA were enabled for them in linux already -- at that time any breakage were solely due to the particular disk model, and were easy to blacklist, if necessary, since only a few disk models were in production. With SATA disks, initial hardware implementation proved to be more non-functional than functional, ie, initially there were more drives with non-working FUA. I have a few not-so-old SATA drives here which behaves strangely when FUA is enabled (I don't remember exact details, but I had to disable FA again after I tried to enable it once, the system started behaving not as good as before). So, for SATA drives, we've exactly the opposite picture: we've some proof that "generally, drives dislikes FUA", and now when fua has been disabled for a lot of drives and users, turning it on by default needs lots of testing. But I ask again: what is the benefit of turning FUA on to start with? Thanks, /mjt