From: Pavel Emelyanov <xemul@parallels.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <jbottomley@parallels.com>
Subject: Re: [rfc 3/7] procfs: Add ability to plugin auxiliary fdinfo providers
Date: Wed, 04 Jul 2012 11:39:30 +0400 [thread overview]
Message-ID: <4FF3F332.5030302@parallels.com> (raw)
In-Reply-To: <20120627110512.574379921@openvz.org>
On 06/27/2012 03:01 PM, Cyrill Gorcunov wrote:
> This patch brings ability to plugin auxiliary fdinfo providers.
> For example in further patches eventfd, evenpoll and fsnotify
> will print out information associated with files.
>
> This feature is CONFIG_CHECKPOINT_RESTORE guarded to eliminate
> overhead for those who don't need it at all (this
> unfortunately makes patch bigger than I wanted).
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> CC: Al Viro <viro@ZenIV.linux.org.uk>
> CC: Alexey Dobriyan <adobriyan@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Pavel Emelyanov <xemul@parallels.com>
> CC: James Bottomley <jbottomley@parallels.com>
> ---
> fs/proc/fd.c | 208 ++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/proc_fs.h | 28 ++++++
> 2 files changed, 236 insertions(+)
How about introducing one more file_operations member and call it in the
seq_show() (if exists)? Only inotify, eventfd and eventpoll will implement
one. This will allow to avoid all this complexity with drivers.
next prev parent reply other threads:[~2012-07-04 7:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 11:01 [rfc 0/7] [rfc] procfs, fdinfo seqfile providers Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 1/7] procfs: Move /proc/pid/fd[info] handling code to fd.[ch] Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file Cyrill Gorcunov
2012-07-04 7:37 ` Pavel Emelyanov
2012-07-04 8:03 ` Cyrill Gorcunov
2012-07-05 17:37 ` Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 3/7] procfs: Add ability to plugin auxiliary fdinfo providers Cyrill Gorcunov
2012-07-04 7:39 ` Pavel Emelyanov [this message]
2012-07-04 7:50 ` Cyrill Gorcunov
2012-07-05 17:44 ` Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 4/7] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 5/7] fs, epoll: " Cyrill Gorcunov
2012-07-19 14:52 ` Matthew Helsley
2012-07-19 15:03 ` Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 6/7] fs, exportfs: Add export_encode_inode_fh helper Cyrill Gorcunov
2012-06-27 11:01 ` [rfc 7/7] fs, notify: Add procfs fdinfo helper Cyrill Gorcunov
2012-06-29 10:30 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3F332.5030302@parallels.com \
--to=xemul@parallels.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=jbottomley@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.