From: Li Zefan <lizefan@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch
Date: Wed, 4 Jul 2012 16:00:43 +0800 [thread overview]
Message-ID: <4FF3F82B.9010704@huawei.com> (raw)
In-Reply-To: <20120704073156.GC9863@dhcp-172-17-9-228.mtv.corp.google.com>
On 2012/7/4 15:32, Joel Becker wrote:
> On Mon, Jan 30, 2012 at 09:51:22PM -0800, Srinivas Eeda wrote:
>> When ocfs2dc thread holds dc_task_lock spinlock and receives soft IRQ it
>> deadlock itself trying to get same spinlock in ocfs2_wake_downconvert_thread.
>> Below is the stack snippet.
>>
>> The patch disables interrupts when acquiring dc_task_lock spinlock.
>>
>> ocfs2_wake_downconvert_thread
>> ocfs2_rw_unlock
>> ocfs2_dio_end_io
>> dio_complete
>> .....
>> bio_endio
>> req_bio_endio
>> ....
>> scsi_io_completion
>> blk_done_softirq
>> __do_softirq
>> do_softirq
>> irq_exit
>> do_IRQ
>> ocfs2_downconvert_thread
>> [kthread]
>>
>> Signed-off-by: Srinivas Eeda <srinivas.eeda@oracle.com>
>
> This patch is now (finally) part of the 'fixes' branch of ocfs2.git.
>
Recently we hit this bug too, and planned to send exactly the same fix..
next prev parent reply other threads:[~2012-07-04 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 5:51 [Ocfs2-devel] [PATCH 1/1] ocfs2: use spinlock irqsave for downconvert lock.patch Srinivas Eeda
2012-01-31 17:52 ` Sunil Mushran
2012-07-04 7:32 ` Joel Becker
2012-07-04 8:00 ` Li Zefan [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-31 5:47 Srinivas Eeda
2012-01-31 5:52 ` srinivas eeda
2012-01-29 2:13 Srinivas Eeda
2012-01-29 2:31 ` Tao Ma
2012-01-29 23:44 ` srinivas eeda
2012-01-30 2:21 ` Tao Ma
2012-01-31 1:43 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3F82B.9010704@huawei.com \
--to=lizefan@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.