From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sha Zhengju Subject: Re: [PATCH 7/7] memcg: print more detailed info while memcg oom happening Date: Wed, 04 Jul 2012 19:20:49 +0800 Message-ID: <4FF42711.50303@gmail.com> References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> <1340881609-5935-1-git-send-email-handai.szj@taobao.com> <4FF3FED6.9010700@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=2jrv1AFmcozevJSzxQuR90AC630qvzUpTd4ezO1FXKM=; b=TXNQK/qChyDv1FlmmLwC2QqA1nK8LbnB1k3cFz6FjxOzuxpahtfxBQcAuLWsNdVvgF em73hes9HNLFQnuCPJvx1gfvJmfgAz9+EUT42RQA/m1VXnsgJ3C1Z/6xXXJ7XubYLXC0 FgGVyAuuuDGTotbXp1q4LZAidkBk+cCXKmyytooBS4X2Hzd/J6zsWEwWJLloCIU/4hOk pnpDsOECgP3H0bUyrjSyW7XZUhkogtmh7IiWbwaCtALoxCjlh6qZAIAj6hZZNG/eqa2x tZCgj3IKMyNT2C/zCKtbs5vkZaU0UCdxAqgTk8An1o7aueuQnsgwRRWEDH8V2MCMQkGD Djdw== In-Reply-To: <4FF3FED6.9010700-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Kamezawa Hiroyuki Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sha Zhengju On 07/04/2012 04:29 PM, Kamezawa Hiroyuki wrote: > (2012/06/28 20:06), Sha Zhengju wrote: >> From: Sha Zhengju >> >> While memcg oom happening, the dump info is limited, so add this >> to provide memcg page stat. >> >> Signed-off-by: Sha Zhengju > Could you split this into a different series ? > seems good to me in general but...one concern is hierarchy handling. > > IIUC, the passed 'memcg' is the root of hierarchy which gets OOM. > So, the LRU info, which is local to the root memcg, may not contain any good > information. I think you should visit all memcg under the tree. > Yes, you're right! I did not handle hierarchy here, and just now I make a test case to prove this. I'll split it to another series later. Thanks for reviewing! Thanks, Sha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx113.postini.com [74.125.245.113]) by kanga.kvack.org (Postfix) with SMTP id F2F9F6B0071 for ; Wed, 4 Jul 2012 07:20:59 -0400 (EDT) Received: by ghrr18 with SMTP id r18so7803448ghr.14 for ; Wed, 04 Jul 2012 04:20:58 -0700 (PDT) Message-ID: <4FF42711.50303@gmail.com> Date: Wed, 04 Jul 2012 19:20:49 +0800 From: Sha Zhengju MIME-Version: 1.0 Subject: Re: [PATCH 7/7] memcg: print more detailed info while memcg oom happening References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> <1340881609-5935-1-git-send-email-handai.szj@taobao.com> <4FF3FED6.9010700@jp.fujitsu.com> In-Reply-To: <4FF3FED6.9010700@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, gthelen@google.com, yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, Sha Zhengju On 07/04/2012 04:29 PM, Kamezawa Hiroyuki wrote: > (2012/06/28 20:06), Sha Zhengju wrote: >> From: Sha Zhengju >> >> While memcg oom happening, the dump info is limited, so add this >> to provide memcg page stat. >> >> Signed-off-by: Sha Zhengju > Could you split this into a different series ? > seems good to me in general but...one concern is hierarchy handling. > > IIUC, the passed 'memcg' is the root of hierarchy which gets OOM. > So, the LRU info, which is local to the root memcg, may not contain any good > information. I think you should visit all memcg under the tree. > Yes, you're right! I did not handle hierarchy here, and just now I make a test case to prove this. I'll split it to another series later. Thanks for reviewing! Thanks, Sha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933264Ab2GDLVC (ORCPT ); Wed, 4 Jul 2012 07:21:02 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33284 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606Ab2GDLU6 (ORCPT ); Wed, 4 Jul 2012 07:20:58 -0400 Message-ID: <4FF42711.50303@gmail.com> Date: Wed, 04 Jul 2012 19:20:49 +0800 From: Sha Zhengju User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: Kamezawa Hiroyuki CC: linux-mm@kvack.org, cgroups@vger.kernel.org, gthelen@google.com, yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, Sha Zhengju Subject: Re: [PATCH 7/7] memcg: print more detailed info while memcg oom happening References: <1340880885-5427-1-git-send-email-handai.szj@taobao.com> <1340881609-5935-1-git-send-email-handai.szj@taobao.com> <4FF3FED6.9010700@jp.fujitsu.com> In-Reply-To: <4FF3FED6.9010700@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/2012 04:29 PM, Kamezawa Hiroyuki wrote: > (2012/06/28 20:06), Sha Zhengju wrote: >> From: Sha Zhengju >> >> While memcg oom happening, the dump info is limited, so add this >> to provide memcg page stat. >> >> Signed-off-by: Sha Zhengju > Could you split this into a different series ? > seems good to me in general but...one concern is hierarchy handling. > > IIUC, the passed 'memcg' is the root of hierarchy which gets OOM. > So, the LRU info, which is local to the root memcg, may not contain any good > information. I think you should visit all memcg under the tree. > Yes, you're right! I did not handle hierarchy here, and just now I make a test case to prove this. I'll split it to another series later. Thanks for reviewing! Thanks, Sha