From: Michal Kazior <michal.kazior@tieto.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Manoharan, Rajkumar" <rmanohar@qca.qualcomm.com>
Subject: Re: [PATCH 06/13] cfg80211: track monitor interfaces count
Date: Wed, 4 Jul 2012 14:34:00 +0200 [thread overview]
Message-ID: <4FF43838.4010908@tieto.com> (raw)
In-Reply-To: <1341401264.12432.7.camel@jlt3.sipsolutions.net>
Johannes Berg wrote:
> On Wed, 2012-07-04 at 13:26 +0200, Johannes Berg wrote:
>> On Wed, 2012-07-04 at 13:17 +0200, Johannes Berg wrote:
>>> On Wed, 2012-07-04 at 13:12 +0200, Johannes Berg wrote:
>>>> Hi Michal,
>>>>
>>>> A few people noticed that these patches cause deadlocks. I think the
>>>> reason is that it's not allowed to lock the device here:
>>>>
>>>>> case NETDEV_DOWN:
>>>>> dev_hold(dev);
>>>>> + cfg80211_lock_rdev(rdev);
>>>>
>>>> This causes a deadlock since the interface is set down inside mac80211
>>>> when inside a handler from cfg80211 already, or so.
>>>
>>> I just reproduce it -- it's because we come from nl80211_del_interface()
>>
>> Ok ... we don't really need to hold the rdev lock since it's all under
>> rtnl. Can you please confirm this is safe?
>>
>> http://p.sipsolutions.net/bde4760671f3e250.txt
>
> I guess we can remove more locking:
> http://p.sipsolutions.net/8a1b875a431e72a0.txt
I can't really test it right now, but it looks good to me.
--
Pozdrawiam / Best regards, Michal Kazior.
next prev parent reply other threads:[~2012-07-04 12:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 10:46 [PATCH v2] respect channels in iface combinations Michal Kazior
2012-06-29 10:46 ` [PATCH 01/13] cfg80211: introduce cfg80211_stop_ap Michal Kazior
2012-06-29 10:46 ` [PATCH 02/13] cfg80211: .stop_ap when interface is going down Michal Kazior
2012-06-29 10:46 ` [PATCH 03/13] cfg80211: add channel tracking for AP and mesh Michal Kazior
2012-06-29 10:46 ` [PATCH 04/13] cfg80211: track ibss fixed channel Michal Kazior
2012-06-29 10:47 ` [PATCH 05/13] cfg80211: introduce cfg80211_get_chan_state Michal Kazior
2012-06-29 10:47 ` [PATCH 06/13] cfg80211: track monitor interfaces count Michal Kazior
2012-07-04 11:12 ` Johannes Berg
2012-07-04 11:17 ` Johannes Berg
2012-07-04 11:26 ` Johannes Berg
2012-07-04 11:27 ` Johannes Berg
2012-07-04 12:34 ` Michal Kazior [this message]
2012-07-04 12:46 ` Rajkumar Manoharan
2012-06-29 10:47 ` [PATCH 07/13] mac80211: refactor virtual monitor code Michal Kazior
2012-06-29 10:47 ` [PATCH 08/13] cfg80211: refuse to .set_monitor_channel when non-monitors are present Michal Kazior
2012-06-29 10:47 ` [PATCH 09/13] cfg80211: track monitor channel Michal Kazior
2012-06-29 10:47 ` [PATCH 10/13] cfg80211: set initial " Michal Kazior
2012-06-29 10:47 ` [PATCH 11/13] cfg80211/mac80211: remove .get_channel Michal Kazior
2012-06-29 10:47 ` [PATCH 12/13] cfg80211: add channel checking for iface combinations Michal Kazior
2012-06-29 10:47 ` [PATCH 13/13] cfg80211: respect iface combinations when starting operation Michal Kazior
2012-06-29 12:22 ` [PATCH v2] respect channels in iface combinations Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 10:06 [PATCH] " Michal Kazior
2012-06-28 10:06 ` [PATCH 06/13] cfg80211: track monitor interfaces count Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF43838.4010908@tieto.com \
--to=michal.kazior@tieto.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.