From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmYPp-0008PD-O4 for qemu-devel@nongnu.org; Wed, 04 Jul 2012 18:51:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmYPn-0004DZ-Op for qemu-devel@nongnu.org; Wed, 04 Jul 2012 18:51:21 -0400 Message-ID: <4FF4C8E0.7020700@suse.de> Date: Thu, 05 Jul 2012 00:51:12 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1341422373-13614-1-git-send-email-afaerber@suse.de> <1341422373-13614-2-git-send-email-afaerber@suse.de> <20120704212050.GD27653@redhat.com> In-Reply-To: <20120704212050.GD27653@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 01/14] pci: Make host bridge TypeInfos const List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jbaron@redhat.com, qemu-devel@nongnu.org, Alexander Graf , qemu-ppc , anthony@codemonkey.ws, pbonzini@redhat.com Am 04.07.2012 23:20, schrieb Michael S. Tsirkin: > On Wed, Jul 04, 2012 at 07:19:20PM +0200, Andreas F=E4rber wrote: >> Also give the sPAPR host bridge type registration functions a unique >> name. >> >> Signed-off-by: Andreas F=E4rber >=20 > I'd like to note that this is a bad practice. > Yoy write one thing in the 1 line summary > and then in the full commit log you > write about other unrelated stuff. (It seemed related by the proximity to the TypeInfo fwiw.) > Make it a separate patch. Do you request that for Coding Style fixes, too? See QOM'ify prep_pci for an example that removed the only remaining violations in the file while touching code above and below. Background of why v2 already did multiple things at once (without anyone complaining) was that Anthony complained that my CPU refactorings were too long and not doing enough in one patch. I'm already up from 2 to 14 here and don't mind splitting things up further again but I don't think there's sufficient reason that warrants having a patch that just renames the function for aesthetics. Would you be okay with moving it into the corresponding QOM'ify sPAPR patch or the final "Tidy up" patch instead? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg