From: Ike Panhc <ike.pan@canonical.com>
To: Maxim Mikityanskiy <maxtram95@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] drivers/platform/x86: Lenovo IdeaPad Z570 support
Date: Thu, 05 Jul 2012 19:09:58 +0800 [thread overview]
Message-ID: <4FF57606.7070806@canonical.com> (raw)
In-Reply-To: <4FF45C98.60305@gmail.com>
Thanks. I have the patch tested on my ideapads. They all looks fine.
The last thing I need is ACK for psmouse patch.
On 07/04/2012 11:09 PM, Maxim Mikityanskiy wrote:
>> Hi Maxim,
>>
>> I separate your patch into three smaller patch. It makes me easier to understand the detail. Please review if all function are still working fine on your ideapad
>
> Hello Ike,
>
> I have tested these patches and there is one problem in the part 2 of patch.
> Build fails, because you missed '+#include <linux/i8042.h>' line of original
> patch. Errors are at lines:
>
>> + i8042_command(¶m, value ? I8042_CMD_AUX_ENABLE :
>> + I8042_CMD_AUX_DISABLE);
>
> When I add '#include <linux/i8042.h>' manually, build succeeds and all
> functions work properly. Please add missing include to the second patch.
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-07-05 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 11:56 [PATCH] drivers/platform/x86: Lenovo IdeaPad Z570 support Maxim Mikityanskiy
2012-06-26 18:31 ` Matthew Garrett
2012-06-28 9:55 ` Ike Panhc
2012-07-04 10:09 ` Ike Panhc
2012-07-04 15:09 ` Maxim Mikityanskiy
2012-07-05 11:09 ` Ike Panhc [this message]
2012-07-05 11:41 ` Maxim Mikityanskiy
2012-07-06 8:07 ` [PATCH 0/4] ideapad: patches for v3.6 merge window Ike Panhc
2012-07-06 8:07 ` [PATCH 1/4] ideapad: uninitialized data in ideapad_acpi_add() Ike Panhc
2012-07-06 8:07 ` [PATCH 2/4] ideapad: add Lenovo IdeaPad Z570 support (part 1) Ike Panhc
2012-07-06 8:08 ` [PATCH 3/4] ideapad: add Lenovo IdeaPad Z570 support (part 2) Ike Panhc
2012-07-06 8:08 ` [PATCH 4/4] ideapad: add Lenovo IdeaPad Z570 support (part 3) Ike Panhc
2012-07-28 4:08 ` [PATCH 0/4] ideapad: patches for v3.6 merge window Matthew Garrett
2012-07-30 1:39 ` Ike Panhc
2012-08-03 12:01 ` Максим Микитянский
2012-07-04 10:17 ` [PATCH 1/3] ideapad: add Lenovo IdeaPad Z570 support (part 1) Ike Panhc
2012-07-04 10:17 ` [PATCH 2/3] ideapad: add Lenovo IdeaPad Z570 support (part 2) Ike Panhc
2012-07-04 10:17 ` [PATCH 3/3] ideapad: add Lenovo IdeaPad Z570 support (part 3) Ike Panhc
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 15:50 [PATCH] drivers/platform/x86: Lenovo IdeaPad Z570 support Максим Микитянский
2012-05-22 4:04 ` Ike Panhc
2012-05-22 8:53 ` Максим Микитянский
2012-05-25 10:19 ` Максим Микитянский
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF57606.7070806@canonical.com \
--to=ike.pan@canonical.com \
--cc=maxtram95@gmail.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.