From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] buildsys: Move msi[x] and virtio-pci from Makefile.objs to Makefile.target Date: Thu, 05 Jul 2012 16:50:22 +0200 Message-ID: <4FF5A9AE.3060501@siemens.com> References: <1341495312-1263-1-git-send-email-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Hans de Goede Return-path: Received: from thoth.sbs.de ([192.35.17.2]:18868 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528Ab2GEOu1 (ORCPT ); Thu, 5 Jul 2012 10:50:27 -0400 In-Reply-To: <1341495312-1263-1-git-send-email-hdegoede@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-07-05 15:35, Hans de Goede wrote: > Building non-kvm versions of qemu from qemu-kvm.git results in a linker error > with undefined references to kvm_kernel_irqchip, expanded from the > kvm_irqchip_in_kernel macro in kvm.h: > > This patch fixes this. > > Note maybe a better fix would be to drop the test for !defined NEED_CPU_H > in the above macro ? The best solution is to push device assignment upstream and celebrate the funeral of qemu-kvm. ;) Until then, qemu-kvm-1.1 (not master) just has to pick "kvm: Enable use of kvm_irqchip_in_kernel in hwlib code" (bbf3b80401) from upstream. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux