From: Antti Palosaari <crope@iki.fi>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH 3/3] [media] tuner, xc2028: add support for get_afc()
Date: Thu, 05 Jul 2012 18:05:36 +0300 [thread overview]
Message-ID: <4FF5AD40.3070707@iki.fi> (raw)
In-Reply-To: <1341497792-6066-3-git-send-email-mchehab@redhat.com>
On 07/05/2012 05:16 PM, Mauro Carvalho Chehab wrote:
> Implement API support to return AFC frequency shift, as this device
> supports it. The only other driver that implements it is tda9887,
> and the frequency there is reported in Hz. So, use Hz also for this
> tuner.
What is AFC and why it is needed?
> +
> + if (frq_lock)
> + break;
> + msleep(6);
6 ms is too small value for msleep(). you should use usleep_range() instead.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-07-05 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 14:16 [PATCH 1/3] [media] tuner-core: call has_signal for both TV and radio Mauro Carvalho Chehab
2012-07-05 14:16 ` [PATCH 2/3] [media] tuner-xc2028: Fix signal strength report Mauro Carvalho Chehab
2012-07-05 14:25 ` Devin Heitmueller
2012-07-05 14:31 ` Devin Heitmueller
2012-07-05 15:40 ` Mauro Carvalho Chehab
2012-07-05 14:16 ` [PATCH 3/3] [media] tuner, xc2028: add support for get_afc() Mauro Carvalho Chehab
2012-07-05 15:05 ` Antti Palosaari [this message]
2012-07-05 17:37 ` Bert Massop
2012-07-05 20:10 ` Mauro Carvalho Chehab
2012-07-07 10:46 ` Antti Palosaari
2012-08-06 20:10 ` Antti Palosaari
2012-08-06 20:41 ` Mauro Carvalho Chehab
2012-08-06 20:37 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5AD40.3070707@iki.fi \
--to=crope@iki.fi \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.