From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ivan Ivanich <ivanich@ivanich.org.ua>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: Trial change to rtl8192ce used as AP
Date: Thu, 05 Jul 2012 15:29:45 -0500 [thread overview]
Message-ID: <4FF5F939.8070008@lwfinger.net> (raw)
In-Reply-To: <1670791.qBDPst6NTM@ivanich.org.ua>
On 07/05/2012 03:24 PM, Ivan Ivanich wrote:
> On Четверг, 05-июл-2012 15:16:00 Larry Finger wrote:
>> Ivan,
>>
>> The following patch is suggested by the code-analysis tool cppcheck as the
>> test is always false. As it will not affect STA usage, I have no way to
>> test the change. Could you please do so?
>>
>> Thanks,
>>
>> Larry
>>
>>
>> Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
>> ===================================================================
>> --- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
>> +++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
>> @@ -1097,7 +1097,7 @@ static int _rtl92ce_set_media_status(str
>>
>> rtl_write_byte(rtlpriv, (MSR), bt_msr);
>> rtlpriv->cfg->ops->led_control(hw, ledaction);
>> - if ((bt_msr & 0xfc) == MSR_AP)
>> + if ((bt_msr & 0x03) == MSR_AP)
>> rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
>> else
>> rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
>
> Yes, compiling now, for some reason it doesn't apply cleanyl so I manualy
> changed this line.
> And what exactly I should test?
Does it affect operation in AP mode? Before this change, the code always wrote
0x66 to the register. Now it seems that it will write 0 if in AP mode. As I have
no idea what that register does, I do not know what effect the change will have.
Larry
next prev parent reply other threads:[~2012-07-05 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 20:16 Trial change to rtl8192ce used as AP Larry Finger
2012-07-05 20:24 ` Ivan Ivanich
2012-07-05 20:29 ` Larry Finger [this message]
2012-07-05 20:48 ` Ivan Ivanich
2012-07-05 21:10 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5F939.8070008@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ivanich@ivanich.org.ua \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.