From mboxrd@z Thu Jan 1 00:00:00 1970 From: shinya.kuribayashi.px@renesas.com (Shinya Kuribayashi) Date: Fri, 06 Jul 2012 13:56:30 +0900 Subject: [PATCH 2/3] hwspinlock/core: add notes on lock element in 'struct hwspinlock' In-Reply-To: <4FF66FBD.5090601@renesas.com> References: <4FF66FBD.5090601@renesas.com> Message-ID: <4FF66FFE.2020803@renesas.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 'lock' must be placed at the end of struct hwspinlock_device because we're doing 'hwlock = &bank->lock[0]' to get a pointer to the first 'struct hwspinlock' instance. Signed-off-by: Shinya Kuribayashi --- drivers/hwspinlock/hwspinlock_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwspinlock/hwspinlock_internal.h b/drivers/hwspinlock/hwspinlock_internal.h index d26f78b..c60318c 100644 --- a/drivers/hwspinlock/hwspinlock_internal.h +++ b/drivers/hwspinlock/hwspinlock_internal.h @@ -57,7 +57,8 @@ struct hwspinlock { * @ops: platform-specific hwspinlock handlers * @base_id: id index of the first lock in this device * @num_locks: number of locks in this device - * @lock: dynamically allocated array of 'struct hwspinlock' + * @lock: dynamically allocated array of 'struct hwspinlock' (must be placed + * at the end of the hwspinlock_device) */ struct hwspinlock_device { struct device *dev; -- 1.7.11.1