From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn197-0006U6-3y for qemu-devel@nongnu.org; Fri, 06 Jul 2012 01:32:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn195-000877-7H for qemu-devel@nongnu.org; Fri, 06 Jul 2012 01:32:00 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:55288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn195-000873-12 for qemu-devel@nongnu.org; Fri, 06 Jul 2012 01:31:59 -0400 Message-ID: <4FF6784A.3060708@weilnetz.de> Date: Fri, 06 Jul 2012 07:31:54 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1341523740-22711-1-git-send-email-peter.maydell@linaro.org> <1341523740-22711-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1341523740-22711-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] target-i386: Remove unused macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , qemu-devel@nongnu.org, patches@linaro.org Am 05.07.2012 23:28, schrieb Peter Maydell: > Commit 11f8cdb removed all the uses of the X86_64_ONLY > macro. The BUGGY_64() macro has been unused for a long time: > it originally marked some ops which couldn't be enabled > because of issues with the pre-TCG code generation scheme. > Remove the now-unnecessary definitions of both macros. > > Signed-off-by: Peter Maydell > --- > target-i386/translate.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/target-i386/translate.c b/target-i386/translate.c > index a00a6a1..8d696ea 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -38,17 +38,11 @@ > #define PREFIX_ADR 0x10 > > #ifdef TARGET_X86_64 > -#define X86_64_ONLY(x) x > #define X86_64_DEF(...) __VA_ARGS__ > #define CODE64(s) ((s)->code64) > #define REX_X(s) ((s)->rex_x) > #define REX_B(s) ((s)->rex_b) > -/* XXX: gcc generates push/pop in some opcodes, so we cannot use them */ > -#if 1 > -#define BUGGY_64(x) NULL > -#endif > #else > -#define X86_64_ONLY(x) NULL > #define X86_64_DEF(...) > #define CODE64(s) 0 > #define REX_X(s) 0 Reviewed-by: Stefan Weil