From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn7SN-00074N-UC for qemu-devel@nongnu.org; Fri, 06 Jul 2012 08:16:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn7SH-0007Ln-GP for qemu-devel@nongnu.org; Fri, 06 Jul 2012 08:16:19 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:17253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn7SH-0007L1-5Z for qemu-devel@nongnu.org; Fri, 06 Jul 2012 08:16:13 -0400 Received: from epcpsbgm1.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M6Q00FDGNER8KZ0@mailout1.samsung.com> for qemu-devel@nongnu.org; Fri, 06 Jul 2012 21:16:07 +0900 (KST) Received: from [172.21.111.108] ([182.198.1.3]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M6Q003SINEV1X10@mmp1.samsung.com> for qemu-devel@nongnu.org; Fri, 06 Jul 2012 21:16:07 +0900 (KST) Date: Fri, 06 Jul 2012 21:16:08 +0900 From: Yeongkyoon Lee In-reply-to: Message-id: <4FF6D708.4030908@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <1341494619-4714-1-git-send-email-yeongkyoon.lee@samsung.com> <1341494619-4714-3-git-send-email-yeongkyoon.lee@samsung.com> Subject: Re: [Qemu-devel] [RFC][PATCH v2 2/4] tcg: add extended MMU helpers to softmmu targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: laurent.desnogues@gmail.com, Peter Maydell , chenwj@iis.sinica.edu.tw, qemu-devel@nongnu.org, e.voevodin@samsung.com On 2012=EB=85=84 07=EC=9B=94 06=EC=9D=BC 03:49, Blue Swirl wrote: > On Thu, Jul 5, 2012 at 1:43 PM, Peter Maydell wrote: >> On 5 July 2012 14:23, Yeongkyoon Lee = wrote: >>> Add extended MMU helpers to softmmu targets, where the targets ar= e alpha, arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, s= h4, sparc and xtensa. >>> >>> Signed-off-by: Yeongkyoon Lee >>> --- >>> target-alpha/mem_helper.c | 22 ++++++++++++++++++++++ >>> target-arm/op_helper.c | 23 +++++++++++++++++++++++ >>> target-cris/op_helper.c | 22 ++++++++++++++++++++++ >>> target-i386/mem_helper.c | 22 ++++++++++++++++++++++ >>> target-lm32/op_helper.c | 23 ++++++++++++++++++++++- >>> target-m68k/op_helper.c | 22 ++++++++++++++++++++++ >>> target-microblaze/op_helper.c | 22 ++++++++++++++++++++++ >>> target-mips/op_helper.c | 22 ++++++++++++++++++++++ >>> target-ppc/mem_helper.c | 22 ++++++++++++++++++++++ >>> target-s390x/op_helper.c | 22 ++++++++++++++++++++++ >>> target-sh4/op_helper.c | 22 ++++++++++++++++++++++ >>> target-sparc/ldst_helper.c | 23 +++++++++++++++++++++++ >>> target-xtensa/op_helper.c | 22 ++++++++++++++++++++++ >>> 13 files changed, 288 insertions(+), 1 deletions(-) >> This makes the already slightly repetitive inclusion of the >> softmmu_templates even more repetitive. Perhaps we could abstract >> it all out into a single header which the targets can include? > I'd just replace standard versions with extended versions > unconditionally, no CONFIG_*. Both AREG0 and !AREG0 cases must be > handled. > I've only modified the code related to the MMU call from generated co= de=20 because this patch is focused optimize that kind of runtime generated= =20 code. As I mentioned another thread, basically I agree to apply AREG0= =20 case if ldst optimization is accepted as default (no macros). But when replacing standard versions with extended versions, there is= an=20 issue of non-x86 (and x64) hosts which has no ldst optimization impl.= It=20 needs to conserve the usage of conditional macro for standard version= s,=20 however, it looks better have a type of version per a host, which is= =20 different from current my patch. How do you think about it?