From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: fix crash with single-queue drivers
Date: Fri, 06 Jul 2012 08:15:55 -0500 [thread overview]
Message-ID: <4FF6E50B.4090205@lwfinger.net> (raw)
In-Reply-To: <1341399225-12604-1-git-send-email-johannes@sipsolutions.net>
On 07/04/2012 05:53 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Larry (and some others I think) reported that with
> single-queue drivers mac80211 crashes when waking
> the queues. This happens because we allocate just
> a single queue for each virtual interface in case
> the driver doesn't have at least 4 queues, but the
> code stopping/waking the virtual interface queues
> wasn't taking this into account.
>
> Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/mac80211/util.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
This patch fixes the problem for drivers that always report a single queue such
as at76c503-usb. There is still a problem for b43 with open-source firmware
where the number of queues changes from 4 to 1. As that only affects b43, do you
agree that the problem should be fixed there?
Larry
next prev parent reply other threads:[~2012-07-06 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 10:53 [PATCH] mac80211: fix crash with single-queue drivers Johannes Berg
2012-07-04 11:01 ` Johannes Berg
2012-07-06 13:15 ` Larry Finger [this message]
2012-07-06 13:26 ` Johannes Berg
2012-07-06 14:12 ` Larry Finger
2012-07-06 14:14 ` Johannes Berg
2012-07-17 10:58 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF6E50B.4090205@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.