From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8n5-0007e4-49 for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:41:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn8n3-0003BC-5A for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:41:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49661 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8n2-0003Aw-Vc for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:41:45 -0400 Message-ID: <4FF6EB13.3070107@suse.de> Date: Fri, 06 Jul 2012 15:41:39 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1340888154-31903-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1340888154-31903-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jia Liu , patches@linaro.org, Jay Foad , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Eric Blake Am 28.06.2012 14:55, schrieb Peter Maydell: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. >=20 > Suggested-by: Jia Liu > Suggested-by: Avi Kivity > Signed-off-by: Peter Maydell > --- > Changes: > v1->v2: added missing brackets > v2->v3: renamed field32,field64 to extract32,extract64 > added deposit32,deposit64 at Avi's suggestion > fixed assertion as per Jay Foad's suggestion > bikeshed roof is now a slightly darker shade of grey Reviewed-by: Andreas F=E4rber Small improvement would be to replace "Returns the" with "Returns: The" in line with how you annotated the arguments, and the function summary should go into its own paragraph between @foo: and Returns:. http://developer.gnome.org/gtk-doc-manual/unstable/documenting_symbols.ht= ml.en Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg