From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54246 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757488Ab2GFPMd (ORCPT ); Fri, 6 Jul 2012 11:12:33 -0400 Message-ID: <4FF7005D.6020809@redhat.com> Date: Fri, 06 Jul 2012 12:12:29 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Ezequiel Garcia CC: linux-media Subject: Re: [PATCH] em28xx: Remove useless runtime->private_data usage References: <1339509222-2714-1-git-send-email-elezegarcia@gmail.com> <1339509222-2714-2-git-send-email-elezegarcia@gmail.com> <4FF5C77C.7030500@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 06-07-2012 11:33, Ezequiel Garcia escreveu: > Mauro, > > On Thu, Jul 5, 2012 at 2:22 PM, Ezequiel Garcia >> Are you sure that > this can be removed? I think this is used internally >>> by the alsa API, but maybe something has changed and this is not >>> required anymore. >> >> Yes, I'm sure. >> > > This should be: "I'm almost sure" :-) > Anyway, probably the patch should have a more verbose commit > message, right? Yeah, that would be good. > Do you want to do drop it entirely? No, but, as I'm taking a 2-week vacations starting next week, I'll postpone those "compiled-only" cleanup patches to apply after my return, probably holding them to be applied on 3.6. Regards, Mauro