From: Daniel Hazelton <dshadowwolf@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM
Date: Fri, 06 Jul 2012 11:54:49 -0400 [thread overview]
Message-ID: <4FF70A49.3040802@gmail.com> (raw)
In-Reply-To: <CAH9JG2XzWS_PF8E4V2bHjq=PtTMEtdDcm1Q03GxK8h4E28Rpjw@mail.gmail.com>
On 07/06/2012 11:32 AM, Kyungmin Park wrote:
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> On Sat, Jul 7, 2012 at 12:28 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/staging/ccg/ccg.c | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c
>> index a5b36a9..62f5d92 100644
>> --- a/drivers/staging/ccg/ccg.c
>> +++ b/drivers/staging/ccg/ccg.c
>> @@ -564,9 +564,7 @@ static int rndis_function_bind_config(struct ccg_usb_function *f,
>> return -1;
>> }
>>
>> - pr_info("%s MAC: %02X:%02X:%02X:%02X:%02X:%02X\n", __func__,
>> - rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>> - rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>> + pr_info("%s MAC: pM\n", __func__, rndis->ethaddr);
You lost a % there - it should be "%s MAC: %pM\n", no ?
DRH
>>
>> ret = gether_setup_name(c->cdev->gadget, rndis->ethaddr, "rndis");
>> if (ret) {
>> @@ -654,9 +652,7 @@ static ssize_t rndis_ethaddr_show(struct device *dev,
>> {
>> struct ccg_usb_function *f = dev_get_drvdata(dev);
>> struct rndis_function_config *rndis = f->config;
>> - return sprintf(buf, "%02x:%02x:%02x:%02x:%02x:%02x\n",
>> - rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>> - rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>> + return sprintf(buf, "%pM\n", rndis->ethaddr);
>> }
>>
>> static ssize_t rndis_ethaddr_store(struct device *dev,
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2012-07-06 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 15:28 [PATCH 1/6] staging: bcm: use %pM to print MAC addresses Andy Shevchenko
2012-07-06 15:28 ` [PATCH 2/6] staging: csr: print MAC addresses via %pM Andy Shevchenko
2012-07-06 15:28 ` [PATCH 3/6] staging: gdm72xx: use %pM for MAC Andy Shevchenko
2012-07-06 15:28 ` [PATCH 4/6] staging: vt6655: use %pM for BSSID Andy Shevchenko
2012-07-06 15:28 ` [PATCH 5/6] staging: vt6656: use %pM for the BSSID Andy Shevchenko
2012-07-06 15:28 ` [PATCH 6/6] staging: ccg: print MAC addresses via %pM Andy Shevchenko
2012-07-06 15:32 ` Kyungmin Park
2012-07-06 15:39 ` [Patch v2] " Andy Shevchenko
2012-07-06 15:54 ` Daniel Hazelton [this message]
2012-07-06 15:57 ` [PATCH 6/6] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF70A49.3040802@gmail.com \
--to=dshadowwolf@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andrzej.p@samsung.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.