From: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
To: habanero@linux.vnet.ibm.com
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] add PLE stats to kvmstat
Date: Sat, 07 Jul 2012 01:40:56 +0800 [thread overview]
Message-ID: <4FF72328.4060907@gmail.com> (raw)
In-Reply-To: <1341580976.12425.50.camel@oc2024037011.ibm.com>
On 07/06/2012 09:22 PM, Andrew Theurer wrote:
> On Fri, 2012-07-06 at 15:42 +0800, Xiao Guangrong wrote:
>> On 07/06/2012 05:50 AM, Andrew Theurer wrote:
>>> I, and I expect others, have a keen interest in knowing how often we
>>> exit for PLE, and also how often that includes a yielding to another
>>> vcpu. The following adds two more counters to kvmstat to track the
>>> exits and the vcpu yields. This in no way changes PLE behavior, just
>>> helps us track what's going on.
>>>
>>
>> Tracepoint is a better choice than the counters you used. :)
>
> Xiao, is kvmstat considered to be deprecated? Or are debug stats like
> this just generally favored to be processed via something like perf
> instead of debugfs?
Andrew, please refer to Documentation/feature-removal-schedule.txt,
it says:
What: KVM debugfs statistics
When: 2013
Why: KVM tracepoints provide mostly equivalent information in a much more
flexible fashion.
You can use tracepoints instead of your debugfs-counters in this patch.
> Should we be removing kvmstat?
>
Some months ago, i implemented 'perf kvm-events' which can analyse kvm
events more smartly, the patchset can be found at:
https://lkml.org/lkml/2012/3/6/86
Avi said it may instead of kvmstat, but i am too busy to update this
patchset. :)
next prev parent reply other threads:[~2012-07-06 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 21:50 [PATCH] add PLE stats to kvmstat Andrew Theurer
2012-07-06 7:42 ` Xiao Guangrong
2012-07-06 13:22 ` Andrew Theurer
2012-07-06 17:40 ` Xiao Guangrong [this message]
2012-07-06 18:12 ` Andrew Theurer
2012-07-08 9:50 ` Avi Kivity
2012-07-09 6:42 ` Xiao Guangrong
2012-07-09 10:52 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF72328.4060907@gmail.com \
--to=xiaoguangrong.eric@gmail.com \
--cc=habanero@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.