From: Fabio Estevam <fabio.estevam@freescale.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: kernel@pengutronix.de, linux-input@vger.kernel.org, festevam@gmail.com
Subject: Re: [PATCH v2 3/3] keyboard: imx_keypad: Check error returned by clk_prepare_enable()
Date: Fri, 6 Jul 2012 15:46:33 -0300 [thread overview]
Message-ID: <4FF73289.8020209@freescale.com> (raw)
In-Reply-To: <20120706183436.GA31613@core.coreip.homeip.net>
Dmitry Torokhov wrote:
> That would leave "keypad->enabled = true" if clk_prepare_enable() fails.
> You need something like below.
You are right. Thanks for fixing it.
prev parent reply other threads:[~2012-07-06 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 17:41 [PATCH v2 1/3] keyboard: imx_keypad: Use clock_prepare_enable/clk_disable_unprepare() Fabio Estevam
2012-07-06 17:41 ` [PATCH v2 2/3] keyboard: imx_keypad: Adapt the new kpp clock name Fabio Estevam
2012-07-06 17:41 ` [PATCH v2 3/3] keyboard: imx_keypad: Check error returned by clk_prepare_enable() Fabio Estevam
2012-07-06 18:34 ` Dmitry Torokhov
2012-07-06 18:46 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF73289.8020209@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.