All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mr Dash Four <mr.dash.four@googlemail.com>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Netfilter Core Team <netfilter-devel@vger.kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 0/3] ipset: change 'iface' part in hash:net,iface set
Date: Fri, 06 Jul 2012 22:04:39 +0100	[thread overview]
Message-ID: <4FF752E7.90102@googlemail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1207062225290.16055@blackhole.kfki.hu>


> Your example is wrong, because the effect of two command are of course 
> different.
>   
So are yours as well, quite evidently. See my previous reply to Maciej.

> But what I gave above, the results depends from the type of the members of 
> the set list, which is invisible in the command line.
It is quite visible as the 'in' bit suggests (similar to the 'dst' bit).

>  Even if it's 
> stressed in the manpage that "in" is equivalent with "src" but just for 
> the hash:net,iface type,
'In' is defined as match on incoming interface only - if that is not 
clear, then it should be made clear (again, I draw similarities with 
your clarifications of 'src' and 'dst' of the very same issue during the 
last ipset update you've made).

Again, this is a choice for people who understand that choice - if 
someone is uncomfortable with that choice, then s/he is free not to use 
it. if I, on the other hand, am not comfortable with using 'src' and 
'dst' for interface matching (I am sure I am not the only one!) then 
there is a help at hand with the above choice.

>  that is an equivalency and users will expect the 
> same result for the cited commands. And they're right.
>   
How so? How would one expect a match on "income interface only" with a 
match on "source ip addresses, source subnets, source ports, source 
everything else you care to mention ... and income interface" to be an 
"equivalent"? it isn't - not in a million years!


  reply	other threads:[~2012-07-06 21:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 22:34 [PATCH 0/3] ipset: change 'iface' part in hash:net,iface set Mr Dash Four
2012-07-05 22:34 ` [PATCH 1/3] iptables: " Mr Dash Four
2012-07-05 22:34 ` [PATCH 2/3] ipset: " Mr Dash Four
2012-07-05 22:34 ` [PATCH 3/3] " Mr Dash Four
2012-07-06  8:35 ` [PATCH 0/3] " Jozsef Kadlecsik
2012-07-06 19:05   ` Mr Dash Four
2012-07-06 19:11     ` Jan Engelhardt
2012-07-06 19:21       ` Mr Dash Four
2012-07-06 19:44       ` Mr Dash Four
2012-07-06 19:47     ` Jozsef Kadlecsik
2012-07-06 20:19       ` Mr Dash Four
2012-07-06 20:39         ` Jozsef Kadlecsik
2012-07-06 21:04           ` Mr Dash Four [this message]
     [not found]         ` <CAHo-OowHXH9f526QQc4Ln5_P_Osdm1Q_RrBkw83hSGj=oES5ww@mail.gmail.com>
2012-07-06 20:41           ` Mr Dash Four
2012-07-06 20:49             ` Jozsef Kadlecsik
2012-07-06 21:04               ` Mr Dash Four
2012-07-06 21:39                 ` Jozsef Kadlecsik
2012-07-06 22:25                   ` Mr Dash Four
2012-07-07 14:53                     ` Jozsef Kadlecsik
2012-07-07 16:23                       ` Jozsef Kadlecsik
2012-07-08 13:03                         ` Mr Dash Four
2012-07-08 18:55                           ` Jozsef Kadlecsik
2012-07-08 19:03                             ` Mr Dash Four
2012-07-08 19:07                               ` Jozsef Kadlecsik
2012-07-08 19:11                                 ` Mr Dash Four
2012-07-08 20:30                                   ` Jozsef Kadlecsik
2012-07-08 22:10                                     ` Mr Dash Four
2012-07-08 22:20                                       ` Jozsef Kadlecsik
2012-07-08 22:25                                         ` Mr Dash Four
2012-07-08 22:55                                           ` Jozsef Kadlecsik
2012-07-09 20:19                                             ` Mr Dash Four
2012-07-09 22:05                                             ` Mr Dash Four
2012-07-08 13:03                       ` Mr Dash Four
     [not found]                         ` <CAHo-Ooya+1H939TqppUcY+pwprOH34zi-jHtnsN+g522aJ3ctw@mail.gmail.com>
2012-07-08 19:43                           ` Mr Dash Four

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF752E7.90102@googlemail.com \
    --to=mr.dash.four@googlemail.com \
    --cc=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.