All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Kang Kai <kai.kang@windriver.com>
Cc: Zhenfeng.Zhao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] lsbinitscripts: Add a linking for functions.lsbinitscripts
Date: Fri, 06 Jul 2012 17:43:10 -0700	[thread overview]
Message-ID: <4FF7861E.6040702@linux.intel.com> (raw)
In-Reply-To: <e6f7a20a5b94c037c1f234180751ecceba8d2d41.1340873279.git.kai.kang@windriver.com>

On 06/28/2012 02:35 AM, Kang Kai wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
>
> Increase ALTERNATIVE_PRIORITY of functions to be higher than the
> value of package initscript. When lsbinitscripts installed, file
> functions provided by lsbinitscripts will be used.
>
> [YOCTO #2133]
>
> Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/lsb/lsbinitscripts_9.03.bb |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb b/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
> index dd92a92..f324994 100644
> --- a/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
> +++ b/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "SysV init scripts which only is used in an LSB image"
>   SECTION = "base"
>   LICENSE = "GPLv2"
>   DEPENDS = "popt"
> -PR = "r0"
> +PR = "r1"
>
>   LIC_FILES_CHKSUM = "file://COPYING;md5=ebf4e8b49780ab187d51bd26aaa022c6"
>
> @@ -15,7 +15,7 @@ SRC_URI[md5sum] = "668fa2762b57ef75436303857847bba3"
>   SRC_URI[sha256sum] = "d56547a68ce223a7413b2676650b042125f047c8d6d139c5b970e118b3dc958a"
>   inherit update-alternatives
>
> -ALTERNATIVE_PRIORITY = "10"
> +ALTERNATIVE_PRIORITY = "100"
>   ALTERNATIVE_${PN} = "functions"
>   ALTERNATIVE_LINK_NAME[functions] = "${sysconfdir}/init.d/functions"
>
> @@ -23,5 +23,5 @@ do_configure[noexec] = "1"
>
>   do_install(){
>   	install -d ${D}/etc/init.d/
> -	install -m 0755 ${S}/rc.d/init.d/functions ${D}/etc/init.d/functions
> +	install -m 0755 ${S}/rc.d/init.d/functions ${D}/etc/init.d/functions.${BPN}
>   }
>
As Richard already pointed out, this rename during install is not 
needed, it happens automagically via the update-alternatives bbclass, 
this is true with the initscripts recipe also, please fix these two 
issues and we can move forward with this patch.

Thanks
	Sau!




  reply	other threads:[~2012-07-07  0:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  9:35 [PATCH 0/2] Fix lsbinitscripts link problem Kang Kai
2012-06-28  9:35 ` [PATCH 1/2] initscripts: use update-alternative to handle file functions Kang Kai
2012-07-03 13:53   ` Richard Purdie
2012-06-28  9:35 ` [PATCH 2/2] lsbinitscripts: Add a linking for functions.lsbinitscripts Kang Kai
2012-07-07  0:43   ` Saul Wold [this message]
2012-07-09  1:33     ` Kang Kai
2012-07-03  1:42 ` [PATCH 0/2] Fix lsbinitscripts link problem Kang Kai
2012-07-03  4:04   ` Saul Wold
2012-07-03  5:49     ` Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF7861E.6040702@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.