From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SnU2a-0000gr-2N for mharc-grub-devel@gnu.org; Sat, 07 Jul 2012 08:23:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnU2W-0000Xm-RA for grub-devel@gnu.org; Sat, 07 Jul 2012 08:23:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SnU2U-00037F-U3 for grub-devel@gnu.org; Sat, 07 Jul 2012 08:23:08 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:54506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnU2U-00036f-K8 for grub-devel@gnu.org; Sat, 07 Jul 2012 08:23:06 -0400 Received: by wibhq4 with SMTP id hq4so1128503wib.12 for ; Sat, 07 Jul 2012 05:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=V5KQxUye4rPsiv4aVk23SLzJvPCUzTjVAEurV2n34aY=; b=cYMAiNo0EQOgQYaOqntQinSo37Htyav31i5uBNfgcWLSsqyLNEIWSonAa0XIn5DnCm oftaj024FS6zN2MiwRVBGpvF8G/Fn9LzUkRZB8uttSwOS1nI6HpB3c3P6SjM1yTjwAjV urXLCgG6qIUagW3NrV+uViM9VbHHpYnZ2U3nmj1E93/4MT3jtX+LQweiaWEouQEMFVbh 6Dcs0bkowHf661rwnU32NKj9lIn0Vo5XaN2m82fDO9+SWaiRR3y41M4l3n2fjCKitU/D 5Mk/hNEtGFwy2Zz6j/+rcZ2rO4gEgryJy9XTvQC+rZ3z/01ztzReS5M7ddviMkQS/0j/ Ho8Q== Received: by 10.217.2.69 with SMTP id o47mr1587462wes.22.1341663784464; Sat, 07 Jul 2012 05:23:04 -0700 (PDT) Received: from debian.x201.phnet (27-233.197-178.cust.bluewin.ch. [178.197.233.27]) by mx.google.com with ESMTPS id df4sm11357353wib.4.2012.07.07.05.23.03 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 07 Jul 2012 05:23:04 -0700 (PDT) Message-ID: <4FF82A25.9070504@gmail.com> Date: Sat, 07 Jul 2012 14:23:01 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Improve FreeDOS direct loading support compatibility. References: In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig7947543D7CEEAC9A33EF3004" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.171 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2012 12:23:10 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7947543D7CEEAC9A33EF3004 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 30.06.2012 07:43, C. Masloch wrote: > #define GRUB_FREEDOS_SEGMENT 0x60 > +#define GRUB_FREEDOS_ADDR (GRUB_FREEDOS_SEGMENT<<4) > #define GRUB_FREEDOS_STACK_SEGMENT 0x1fe0 > -#define GRUB_FREEDOS_STACK_POINTER 0x8000 > +#define GRUB_FREEDOS_STACK_BPB_POINTER 0x7c00 > +#define GRUB_FREEDOS_BPB_ADDR ((GRUB_FREEDOS_STACK_SEGMENT<<4) = \ > + +GRUB_FREEDOS_STACK_BPB_POINTER)= > + Please put spaces around operators. > + > + /* This is not strictly necessary for the current FreeDOS kernel > + but improves potential compatibility with the current EDR-DOS > + load protocol. DR-DOS is less-known proprietary software which we usually don't support as policy. While it's ok to set those registers, please avoid referencing DR-DOS directly, even in comments. > + /* This check could be considered optional, but it provides a more > + specific error message than grub_relocator_alloc_chunk_addr would= , > + and additionally it insures that a little is set aside for the > + initial stack as well. > + Quirkily, because of its size constraints FreeDOS's original load= er > + doesn't perform such a check at all (and crashes instead). The fi= le > + size limit is documented though. */ > + if (kernelsyssize > GRUB_FREEDOS_MAX_SIZE) > + { > + (void)grub_error (GRUB_ERR_BAD_OS, > + "file `%s' is too large for a valid" > + " FreeDOS kernel.sys", argv[0]); No need of void cast here. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig7947543D7CEEAC9A33EF3004 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/4KiUACgkQNak7dOguQgkHVwEApnbQ4QEnRY2AdnJbUm5BRT8g Tf465etOy3COVD4ejW0A/R4MLMx9waSHG/AV0n/XefYTRxOy4NAhqfE1M2P3PE/j =/J6w -----END PGP SIGNATURE----- --------------enig7947543D7CEEAC9A33EF3004--