From: Jan Ceuleers <jan.ceuleers@computer.org>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: greg@kroah.com, sjakub@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix checkpatch.pl issue.
Date: Sun, 08 Jul 2012 10:36:25 +0200 [thread overview]
Message-ID: <4FF94689.3050701@computer.org> (raw)
In-Reply-To: <1341735405-16997-1-git-send-email-yamanetoshi@gmail.com>
On 07/08/2012 10:16 AM, Toshiaki Yamane wrote:
> -printk(KERN_ERR, to pr_err(...
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Hi
I submit that your subject line should be more descriptive. Perhaps
something like the following:
[PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
The rest of your commit message could then clarify that this change was
inspired by checkpatch.
HTH, Jan
next prev parent reply other threads:[~2012-07-08 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 8:16 [PATCH] Fix checkpatch.pl issue Toshiaki Yamane
2012-07-08 8:36 ` Jan Ceuleers [this message]
2012-07-08 9:16 ` yamanetoshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF94689.3050701@computer.org \
--to=jan.ceuleers@computer.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjakub@gmail.com \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.