All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: Fix inkern remove incorrect put of device
Date: Sun, 08 Jul 2012 10:36:16 +0100	[thread overview]
Message-ID: <4FF95490.6080803@kernel.org> (raw)
In-Reply-To: <1341060923-10311-1-git-send-email-jic23@kernel.org>

On 06/30/2012 01:55 PM, Jonathan Cameron wrote:
> The device_get is after this point so on error we should not be
> removing it.
> 
merged to fixes.
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/iio/inkern.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 9a46ca6..e2aded0 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -193,7 +193,6 @@ struct iio_channel *iio_channel_get_all(const char *name)
>  						c->map->adc_channel_label);
>  		if (chans[mapind].channel == NULL) {
>  			ret = -EINVAL;
> -			iio_device_put(chans[mapind].indio_dev);
>  			goto error_free_chans;
>  		}
>  		iio_device_get(chans[mapind].indio_dev);
> 

      reply	other threads:[~2012-07-08  9:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-30 12:55 [PATCH] iio: Fix inkern remove incorrect put of device Jonathan Cameron
2012-07-08  9:36 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF95490.6080803@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.